From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF414A0350; Fri, 5 Jun 2020 13:45:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E3AA21D5D7; Fri, 5 Jun 2020 13:45:13 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 89DF81D55E for ; Fri, 5 Jun 2020 13:45:11 +0200 (CEST) IronPort-SDR: cJ2zFSKzKcSRFmoYjq2cBcm4JPRnJxNq29Eo3UyIl0+HX4/uAvyPyZ/4sJJ+HaiqvMiVpe8dY+ DUYc25xLXavA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2020 04:45:10 -0700 IronPort-SDR: mnlXjKzlYxlLSsAyOnJ7ESBJYSatvSZbhRCHvu/PYQHpnbXGQabMp4eTuxl2EQjBkmfxe6iMhP Ah1ahIEFAnxw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,476,1583222400"; d="scan'208";a="273448545" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.24.115]) ([10.252.24.115]) by orsmga006.jf.intel.com with ESMTP; 05 Jun 2020 04:45:07 -0700 To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , i.dyukov@samsung.com Cc: dev@dpdk.org, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200526191033.16459-1-i.dyukov@samsung.com> <20200526191033.16459-3-i.dyukov@samsung.com> <98CBD80474FA8B44BF855DF32C47DC35C6100A@smartserver.smartshare.dk> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <52688b41-04b5-803a-c71b-cb82ecd1b842@intel.com> Date: Fri, 5 Jun 2020 12:45:06 +0100 MIME-Version: 1.0 In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C6100A@smartserver.smartshare.dk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/7] ethdev: add a link status textrepresentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/27/2020 8:45 AM, Morten Brørup wrote: >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ivan Dyukov >> Sent: Tuesday, May 26, 2020 9:10 PM >> >> This commit add function which treat link status structure >> and format it to text representation. >> >> Signed-off-by: Ivan Dyukov >> --- >> lib/librte_ethdev/rte_ethdev.c | 39 ++++++++++++++++++++++++++++++++++ >> lib/librte_ethdev/rte_ethdev.h | 31 +++++++++++++++++++++++++++ >> 2 files changed, 70 insertions(+) >> >> diff --git a/lib/librte_ethdev/rte_ethdev.c >> b/lib/librte_ethdev/rte_ethdev.c >> index 8e10a6fc3..8d75c2440 100644 >> --- a/lib/librte_ethdev/rte_ethdev.c >> +++ b/lib/librte_ethdev/rte_ethdev.c >> @@ -2385,6 +2385,45 @@ rte_eth_link_get_nowait(uint16_t port_id, struct >> rte_eth_link *eth_link) >> return 0; >> } >> >> +void >> +rte_eth_link_prepare_text(struct rte_eth_link *eth_link, uint32_t >> speed_unit, >> + struct rte_eth_link_text *link_text) >> +{ >> + uint32_t link_speed = 0; >> + /* prepare link speed */ >> + if (eth_link->link_speed == ETH_SPEED_NUM_UNKNOWN) >> + memcpy(link_text->link_speed, "unknown", >> sizeof("unknown")); >> + else { >> + if (speed_unit == ETH_SPEED_UNIT_GBPS) >> + link_speed = eth_link->link_speed / 1000; >> + else >> + link_speed = eth_link->link_speed; >> + snprintf(link_text->link_speed, sizeof(link_text- >>> link_speed), >> + "%u", link_speed); >> + } >> + /* prepare link duplex */ >> + if (eth_link->link_duplex == ETH_LINK_FULL_DUPLEX) >> + memcpy(link_text->link_duplex, "full-duplex", >> + sizeof("full-duplex")); >> + else >> + memcpy(link_text->link_duplex, "half-duplex", >> + sizeof("half-duplex")); >> + /* prepare autoneg */ >> + if (eth_link->link_autoneg == ETH_LINK_AUTONEG) >> + memcpy(link_text->link_autoneg, "autoneg", >> + sizeof("autoneg")); >> + else >> + memcpy(link_text->link_autoneg, "fixed", >> + sizeof("fixed")); >> + /* prepare status */ >> + if (eth_link->link_status == ETH_LINK_DOWN) >> + memcpy(link_text->link_status, "down", >> + sizeof("down")); >> + else >> + memcpy(link_text->link_status, "up", >> + sizeof("up")); >> +} >> + >> int >> rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) >> { >> diff --git a/lib/librte_ethdev/rte_ethdev.h >> b/lib/librte_ethdev/rte_ethdev.h >> index 2090af501..53d2f0c78 100644 >> --- a/lib/librte_ethdev/rte_ethdev.h >> +++ b/lib/librte_ethdev/rte_ethdev.h >> @@ -316,6 +316,19 @@ struct rte_eth_link { >> uint16_t link_status : 1; /**< ETH_LINK_[DOWN/UP] */ >> } __rte_aligned(8); /**< aligned for atomic64 read/write */ >> >> +/** >> + * Link speed units >> + */ >> +#define ETH_SPEED_UNIT_GBPS 0 >> +#define ETH_SPEED_UNIT_MBPS 1 >> + >> + >> +struct rte_eth_link_text { >> + char link_speed[14]; /** link speed */ >> + char link_duplex[12]; /** full-duplex or half-duplex */ >> + char link_autoneg[8]; /** autoneg or fixed */ >> + char link_status[5]; /** down or up */ >> +}; >> /* Utility constants */ >> #define ETH_LINK_HALF_DUPLEX 0 /**< Half-duplex connection (see >> link_duplex). */ >> #define ETH_LINK_FULL_DUPLEX 1 /**< Full-duplex connection (see >> link_duplex). */ >> @@ -2295,6 +2308,24 @@ int rte_eth_link_get(uint16_t port_id, struct >> rte_eth_link *link); >> */ >> int rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link >> *link); >> >> +/** >> + * Format link status to textual representation. speed_unit is used to >> convert >> + * link_speed to specified unit. Also this function threats a special >> + * ETH_SPEED_NUM_UNKNOWN value of link_speed and return 'UNKNOWN' >> speed >> + * in this case. >> + * >> + * @param link >> + * Link status provided by rte_eth_link_get function >> + * @param speed_unit >> + * Target units for the speed. Following values are available: >> + * - ETH_SPEED_UNIT_GBPS >> + * - ETH_SPEED_UNIT_MBPS >> + * @param link_text >> + * A pointer to an *rte_eth_link_text* structure to be filled with >> + * textual representation of device status >> + */ >> +void rte_eth_link_prepare_text(struct rte_eth_link *link, uint32_t >> speed_unit, >> + struct rte_eth_link_text *link_text); >> /** >> * Retrieve the general I/O statistics of an Ethernet device. >> * >> -- >> 2.17.1 >> > > Considering that this function will only be used by applications that don't need to follow a vendor-specific textual format for their link status, you can choose your own text format, and don't need the struct for the text strings. The function can simply write the entire information into a single string. It also makes speed_unit superfluous. E.g. like this: > > void rte_eth_link_prepare_text(char *str, const struct rte_eth_link *const link) > { > if (link.link_status == ETH_LINK_DOWN) { > str += sprintf(str, "Link down"); > } else { > str += sprintf(str, "Link up at "); > if (link.link_speed == ETH_SPEED_NUM_UNKNOWN) { > str += sprintf("Unknown speed"); > } else { > if (link.link_speed < ETH_SPEED_NUM_1G) > str += sprintf(str, "%u Mbit/s", link.link_speed); > else if (link.link_speed == ETH_SPEED_NUM_2_5G) > str += sprintf(str, "2.5 Gbit/s"); > else > str += sprintf(str, "%u Gbit/s", link.link_speed / 1000); > str += sprintf(str, " %cDX", link.link_duplex ? 'F' : 'H'); > str += sprintf(str, " %s", link.link_autoneg ? "Autoneg" : "Fixed"); > } > } > } > > > And if DPDK already has an established style for "convert information to human readable text" functions regarding function name and parameter order, the function should follow such style. > What about having them both, a per-formatted string that can make life easy for applications, and struct for text strings for the apps need some granularity.