From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-we0-f170.google.com (mail-we0-f170.google.com
 [74.125.82.170]) by dpdk.org (Postfix) with ESMTP id A8E04DE4
 for <dev@dpdk.org>; Wed, 30 Oct 2013 09:52:15 +0100 (CET)
Received: by mail-we0-f170.google.com with SMTP id u57so959812wes.29
 for <dev@dpdk.org>; Wed, 30 Oct 2013 01:53:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=XmtgBE4FYPPCQBzGJdWwdm/JyhlsUmVvnpOMcIeCc10=;
 b=KKN3DVQp8OrTEBNoGo0mAwzaRdEBkPJqL8ZsZZJi0U/TjvEzDOv6VIqgayD7lypn3j
 70pIy4H0tajT8/QHxLi9BGYY2iNamDNhrjPRl17k/OcQg/C0J65M4ztflWEUHIZ0zGUO
 z+eDubF5M+oEOGgziNVH8V0Diuq17ODOr2pTDGxctTZKStXOxO+C8EMpxIrXYFPkCkz/
 dw4DQW2RLshf/dfD8WWpwZoDzHKtk/0xsCrRk6dcQZgPhjzIVh8JoES5JtuiimH925nz
 3t25bKj0teU2yMu+kImEFZPfUsnlHtbkTU7AVeyBgpZ4jyz2k6bje/cWZAYKuLO/lOLu
 QWUw==
X-Gm-Message-State: ALoCoQm7Dl9s3xy3vGeRzNtYVEmdgBBU0YZObUvTTAZGKFsfwn35EgSS0ZIu4yvmALaJhQaZ/8Ou
X-Received: by 10.194.143.18 with SMTP id sa18mr527228wjb.70.1383123186772;
 Wed, 30 Oct 2013 01:53:06 -0700 (PDT)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id q3sm13298626wib.5.2013.10.30.01.53.05
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 30 Oct 2013 01:53:05 -0700 (PDT)
Message-ID: <5270C8F0.1080306@6wind.com>
Date: Wed, 30 Oct 2013 09:53:04 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20131005 Icedove/17.0.9
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1382522765-27254-1-git-send-email-thomas.monjalon@6wind.com>
In-Reply-To: <1382522765-27254-1-git-send-email-thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] config: fix combined/shared lib
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Oct 2013 08:52:15 -0000

Hi Thomas,

 > - Configuration for combined and shared library was only in
 >   the template defconfig_x86_64-default-linuxapp-gcc.
> - CONFIG_RTE_LIBNAME was in the wrong section
> - CONFIG_RTE_LIBNAME quotes were not properly removed in "make context"
> - RTE_LIBNAME had no quote in "C context" (include/rte_config.h)

acked

Just one remark about the commit log: if I understand well, the
issue related to the quote not properly removed in "make context"
is triggered by the quotes you added in the defconfig. I would reword
the commit log a bit to highlight it.

Regards,
Olivier