From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A920D4CB5 for ; Wed, 12 Sep 2018 13:31:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2018 04:31:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,364,1531810800"; d="scan'208";a="69401697" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.37]) ([10.237.221.37]) by fmsmga007.fm.intel.com with ESMTP; 12 Sep 2018 04:31:01 -0700 To: "Yao, Lei A" , "dev@dpdk.org" Cc: "Mcnamara, John" References: <20180830105422.1198-1-david.hunt@intel.com> <20180830105422.1198-7-david.hunt@intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A53BA56@shsmsx102.ccr.corp.intel.com> From: "Hunt, David" Message-ID: <527c2e6f-1183-5b44-9fd3-8566f599c332@intel.com> Date: Wed, 12 Sep 2018 12:31:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A53BA56@shsmsx102.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSON interface API info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 11:31:04 -0000 Hi Lei, On 4/9/2018 6:17 AM, Yao, Lei A wrote: > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt >> Sent: Thursday, August 30, 2018 6:54 PM >> To: dev@dpdk.org >> Cc: Mcnamara, John ; Hunt, David >> >> Subject: [dpdk-dev] [PATCH v1 6/7] doc/vm_power_manager: add JSON >> interface API info >> >> Signed-off-by: David Hunt >> --- >> .../sample_app_ug/vm_power_management.rst | 195 >> ++++++++++++++++++ >> 1 file changed, 195 insertions(+) >> >> diff --git a/doc/guides/sample_app_ug/vm_power_management.rst >> b/doc/guides/sample_app_ug/vm_power_management.rst >> index 855570d6b..13a325eae 100644 >> --- a/doc/guides/sample_app_ug/vm_power_management.rst >> +++ b/doc/guides/sample_app_ug/vm_power_management.rst >> @@ -337,6 +337,201 @@ monitoring of branch ratio on cores doing busy >> polling via PMDs. >> and will need to be adjusted for different workloads. >> >> >> + >> +JSON API >> +~~~~~~~~ >> + --snip-- >> +:Pair Name: "quiet_hours" >> +:Description: The hours of the day in which we scale down the cores for >> quiet >> + times. >> +:Type: array of integers >> +:Values: array with list of hour numbers, (0-23) >> +:Required: only for TIME policy >> +:Example: >> + >> + .. code-block:: console >> + >> + "quiet_hours":[ 2, 3, 4, 5, 6 ] >> + > Do you think we need document following three key here? > min_packet_thresh > avg_packet_thresh > max_packet_thresh > I see them in the code but not documented. > Good catch. I missed these in the docs. Also I checked the code there these are used, and only two are needed. These are avg and max. Below, avg, the freq is set to minimum Between avg and max, the freq us set to medium Above max, the freq is set to maximum. I'll remove the minimum from the code, seeing as it's not used, and document avg and max. Rgds, Dave. --snip--