From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA65BA04B1; Fri, 28 Aug 2020 15:05:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A3461C19C; Fri, 28 Aug 2020 15:05:49 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 5CA861C19B for ; Fri, 28 Aug 2020 15:05:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598619946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=A84l8PVToR2YlJsLWkR2xaN44vBB4srniCv5PiJIEJk=; b=hHccqijnHMbZ1Slm1Pd7Up7PR1Ijc+rAU4MqGhCQqss/otW8YaSox/XWE9P8pvbnFHgVH1 SWm9VoI72RjjK5AFGVdZlQsaXJGIcd88gCdjxhph9J/KSaOcspH+rSfn5UpVCqFdfwEYBU +EiFamJkWYWcDaNztP2skFrhoBml6wo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-575-_IIJ-Y09PhKV4GT74KlvTw-1; Fri, 28 Aug 2020 09:05:44 -0400 X-MC-Unique: _IIJ-Y09PhKV4GT74KlvTw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BF26D420E7; Fri, 28 Aug 2020 13:05:42 +0000 (UTC) Received: from [10.33.36.20] (unknown [10.33.36.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB2A01014168; Fri, 28 Aug 2020 13:05:39 +0000 (UTC) To: Carasec Elena , "Xing, Beilei" Cc: dev@dpdk.org, stable@dpdk.org, "Zhang, Qi Z" , Adrien Mazarguil , Andrew Rybchenko , Luca Boccassi , Jan Viktorin , "Di, ChenxuX" , "Wang, ShougangX" References: <1598441281-11209-1-git-send-email-xcaras00@stud.fit.vutbr.cz> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <52820343-1536-3bae-25b7-a1ea9a1da3fa@redhat.com> Date: Fri, 28 Aug 2020 14:05:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] i40e: fix segfault when using custom RSS key X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 28/08/2020 13:52, Carasec Elena wrote: > Hello, > > We admit that the mistake was from our part. > New tests' results have revealed that from DPDK v20.05 this issue > does not exist anymore. So, this patch is applicable for DPDK > v20.02 and older. > The "Fixed:" commit is first in 18.05, so looks like this is valid for 18.11 and 19.11 LTS branches. Please confirm, and it will need i40e maintainers ack too. thanks, Kevin. > Kind regards, > Elena Carasec > > > > -------- Original Message -------- > Subject: RE: [dpdk-dev] [PATCH] i40e: fix segfault when using custom RSS > key > Date: 2020-08-28 08:38 > From: "Xing, Beilei" > To: Elena Carasec , "dev@dpdk.org" > > >> -----Original Message----- >> From: dev On Behalf Of Elena Carasec >> Sent: Wednesday, August 26, 2020 7:28 PM >> To: dev@dpdk.org >> Cc: Elena Carasec ; stable@dpdk.org; Xing, >> Beilei >> ; Zhang, Qi Z ; Adrien >> Mazarguil ; Andrew Rybchenko >> ; Luca Boccassi ; Jan >> Viktorin >> Subject: [dpdk-dev] [PATCH] i40e: fix segfault when using custom RSS >> key >> >> &out->conf and in can point to the same memory area. Reinitialization >> of >> out->conf leads to setting in->key to NULL, but leaves key_len 40. This >> leads to segfault on destruction of the RSS flow action. The segfault >> happens >> inside i40e_action_rss_same(), when comparing comp->key and >> with->key, because both comp->key_len and with->key_len are 40 (should >> be 0). >> >> Reproduction steps (testpmd): >> >> port stop 0 >> flow create 0 ingress pattern end actions rss func default level 0\ >> key >> 6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5a6d5 >> a6d5a6d5a6d5a6d5a\ >> key_len 40 queues 0 end / end >> port start 0 >> set link-up port 0 >> start >> stop >> set link-down port 0 >> port stop 0 >> flow destroy 0 rule 0 >> (Segmentation fault) > > Hi, > > Thanks for the fix. > But according to Chenxu and Shougang's test, this issue doesn't exist > after DPDK 20.05, > where RSS configuration has been refactored. > Could you please retry with the latest DPDK? > > BR, > Beilei > >> >> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API") >> >> Signed-off-by: Elena Carasec >> Signed-off-by: Jan Viktorin >> --- >> drivers/net/i40e/i40e_ethdev.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/i40e/i40e_ethdev.c >> b/drivers/net/i40e/i40e_ethdev.c >> index 11c02b1..a5fe130 100644 >> --- a/drivers/net/i40e/i40e_ethdev.c >> +++ b/drivers/net/i40e/i40e_ethdev.c >> @@ -13211,6 +13211,8 @@ struct i40e_customized_pctype* >> return -EINVAL; >> if (!in->key && in->key_len) >> return -EINVAL; >> + if (&out->conf == in) >> + return 0; >> out->conf = (struct rte_flow_action_rss){ >> .func = in->func, >> .level = in->level, >> -- >> 1.8.3.1 >