From: Ivan Boule <ivan.boule@6wind.com>
To: Maxime Leroy <maxime.leroy@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] igb/ixgbe: allow RSS with only one Rx queue
Date: Wed, 20 Nov 2013 10:37:34 +0100 [thread overview]
Message-ID: <528C82DE.202@6wind.com> (raw)
In-Reply-To: <1384866215-18420-2-git-send-email-maxime.leroy@6wind.com>
On 11/19/2013 02:03 PM, Maxime Leroy wrote:
> It should be possible to enable RSS with a single Rx queue.
> The RSS hash can be useful independently of the number of RX queues.
> Hence, DPDK applications can use the hardware-computed RSS hash to
> manage in software different IP packet flows.
>
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> ---
> lib/librte_pmd_e1000/igb_rxtx.c | 7 ++-----
> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 7 ++-----
> 2 files changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/lib/librte_pmd_e1000/igb_rxtx.c
> b/lib/librte_pmd_e1000/igb_rxtx.c
> index 641ceea..8c1e2cc 100644
> --- a/lib/librte_pmd_e1000/igb_rxtx.c
> +++ b/lib/librte_pmd_e1000/igb_rxtx.c
> @@ -1743,8 +1743,7 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev)
> /*
> * SRIOV inactive scheme
> */
> - if (dev->data->nb_rx_queues > 1)
> - switch (dev->data->dev_conf.rxmode.mq_mode) {
> + switch (dev->data->dev_conf.rxmode.mq_mode) {
> case ETH_MQ_RX_RSS:
> igb_rss_configure(dev);
> break;
> @@ -1757,9 +1756,7 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev)
> default:
> igb_rss_disable(dev);
> break;
> - }
> - else
> - igb_rss_disable(dev);
> + }
> }
> return 0;
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> index e1b90f9..ae9eda8 100644
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
> @@ -3215,8 +3215,7 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
> * SRIOV inactive scheme
> * any DCB/RSS w/o VMDq multi-queue setting
> */
> - if (dev->data->nb_rx_queues > 1)
> - switch (dev->data->dev_conf.rxmode.mq_mode) {
> + switch (dev->data->dev_conf.rxmode.mq_mode) {
> case ETH_MQ_RX_RSS:
> ixgbe_rss_configure(dev);
> break;
> @@ -3232,9 +3231,7 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
> case ETH_MQ_RX_NONE:
> /* if mq_mode is none, disable rss mode.*/
> default: ixgbe_rss_disable(dev);
> - }
> - else
> - ixgbe_rss_disable(dev);
> + }
> } else {
> switch (RTE_ETH_DEV_SRIOV(dev).active) {
> /*
Acked by Ivan Boule <ivan.boule@6wind.com>
--
Ivan Boule
6WIND Development Engineer
next prev parent reply other threads:[~2013-11-20 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 13:03 [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS Maxime Leroy
2013-11-19 13:03 ` [dpdk-dev] [PATCH 2/2] igb/ixgbe: allow RSS with only one Rx queue Maxime Leroy
2013-11-20 9:37 ` Ivan Boule [this message]
2013-11-20 9:57 ` Thomas Monjalon
2013-11-20 9:49 ` [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS Ivan Boule
2013-11-20 9:56 ` Thomas Monjalon
2013-11-20 10:06 ` Prashant Upadhyaya
2013-11-20 10:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528C82DE.202@6wind.com \
--to=ivan.boule@6wind.com \
--cc=dev@dpdk.org \
--cc=maxime.leroy@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).