From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by dpdk.org (Postfix) with ESMTP id 469B4156 for ; Wed, 20 Nov 2013 10:36:41 +0100 (CET) Received: by mail-ee0-f49.google.com with SMTP id b47so2090309eek.22 for ; Wed, 20 Nov 2013 01:37:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=grTe7YQBV2EpO9oohdMUbpMCzW6nIUnsi98TruklUVQ=; b=GWrlbIeQaiTFuNKectdg8SuvEwUhs9+yV9QFKBA67iQBAU5ORT+XfNMTHGBYCJWcLW fuXG3ABFOGNBnoBndmEe0PpJmjayxK85Fo11qMGHz5o4eA70uHI2ak5DwyWkDR/Asu8F 4USRZZcc/hYasHOH4CkEioweb5W6U86Vj7F2qQi3VVcd42o+/YjXbm51JoJ0mcObbvje HCvohjMSw5zamZfx4nZiebKFoOUxJ9VkG0alNyRBHuOqvxa9ehvV+iiyEP/dV3qGF0Wr pcqL8Zv1yVBObokm5NxHC4dfQkUksWaGRNSjoU87jzkDT2nimvji7nFYFJnQB6yPEUfx P2UA== X-Gm-Message-State: ALoCoQkA5RK+3COgK7g3S+D3UORrl9gHU+tcHBqy2dcwi5H6oPfXWS4XoxgAMy5BX5+pYRyshUEY X-Received: by 10.14.87.3 with SMTP id x3mr839892eee.76.1384940259182; Wed, 20 Nov 2013 01:37:39 -0800 (PST) Received: from [10.16.0.189] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id v45sm7583699eef.11.2013.11.20.01.37.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Nov 2013 01:37:38 -0800 (PST) Message-ID: <528C82DE.202@6wind.com> Date: Wed, 20 Nov 2013 10:37:34 +0100 From: Ivan Boule User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130922 Icedove/17.0.9 MIME-Version: 1.0 To: Maxime Leroy References: <1384866215-18420-1-git-send-email-maxime.leroy@6wind.com> <1384866215-18420-2-git-send-email-maxime.leroy@6wind.com> In-Reply-To: <1384866215-18420-2-git-send-email-maxime.leroy@6wind.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] igb/ixgbe: allow RSS with only one Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 09:36:41 -0000 On 11/19/2013 02:03 PM, Maxime Leroy wrote: > It should be possible to enable RSS with a single Rx queue. > The RSS hash can be useful independently of the number of RX queues. > Hence, DPDK applications can use the hardware-computed RSS hash to > manage in software different IP packet flows. > > Signed-off-by: Maxime Leroy > --- > lib/librte_pmd_e1000/igb_rxtx.c | 7 ++----- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 7 ++----- > 2 files changed, 4 insertions(+), 10 deletions(-) > > diff --git a/lib/librte_pmd_e1000/igb_rxtx.c > b/lib/librte_pmd_e1000/igb_rxtx.c > index 641ceea..8c1e2cc 100644 > --- a/lib/librte_pmd_e1000/igb_rxtx.c > +++ b/lib/librte_pmd_e1000/igb_rxtx.c > @@ -1743,8 +1743,7 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) > /* > * SRIOV inactive scheme > */ > - if (dev->data->nb_rx_queues > 1) > - switch (dev->data->dev_conf.rxmode.mq_mode) { > + switch (dev->data->dev_conf.rxmode.mq_mode) { > case ETH_MQ_RX_RSS: > igb_rss_configure(dev); > break; > @@ -1757,9 +1756,7 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) > default: > igb_rss_disable(dev); > break; > - } > - else > - igb_rss_disable(dev); > + } > } > return 0; > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > index e1b90f9..ae9eda8 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -3215,8 +3215,7 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) > * SRIOV inactive scheme > * any DCB/RSS w/o VMDq multi-queue setting > */ > - if (dev->data->nb_rx_queues > 1) > - switch (dev->data->dev_conf.rxmode.mq_mode) { > + switch (dev->data->dev_conf.rxmode.mq_mode) { > case ETH_MQ_RX_RSS: > ixgbe_rss_configure(dev); > break; > @@ -3232,9 +3231,7 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) > case ETH_MQ_RX_NONE: > /* if mq_mode is none, disable rss mode.*/ > default: ixgbe_rss_disable(dev); > - } > - else > - ixgbe_rss_disable(dev); > + } > } else { > switch (RTE_ETH_DEV_SRIOV(dev).active) { > /* Acked by Ivan Boule -- Ivan Boule 6WIND Development Engineer