From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com [209.85.215.175]) by dpdk.org (Postfix) with ESMTP id 984A55910 for ; Wed, 20 Nov 2013 10:49:04 +0100 (CET) Received: by mail-ea0-f175.google.com with SMTP id z10so1510378ead.34 for ; Wed, 20 Nov 2013 01:49:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=2SoSGKCqjNyVJ8gozdsqepxzpej6d2Cw27opu4GkAjc=; b=mmRA9RefbJMdd2XZ/0ezo2kZI2Kpo0SyL5uxIsKSdrIKX7FILDAlfb+p6Slpg5SEvA Z/W73dhdLdjna+E5JL3hJmqzZfPxMO0mKbgSmNnewmkx1XG3UCk6NHmHFj8F/oz7tDe2 QAi3R0y8KmKoJXniiFgi9ecAQiUT2fQMSBraQkWuOuaAAwkDfil4GeM8NWG40m1wv5Jy /kXpkfbJy/Wvp8Tb1yg+Ab0kKhaiT5mYAjjIFkigEeTXFRqlTIHQhEmCg6Uosc83F2HG /gYEjeMUGnLHvMoZq3ZXxhEKbSjgm4kqByOMRHe+IV8soT+WqAsUxMeEjOJXeW19NrEC ZJDQ== X-Gm-Message-State: ALoCoQmSV3J2+tHuD74hSYfseXd/Ru4D/AePgtXaR/EpOJ+U9ZzhfubJ8gfAv3f+xcW9m5KVJX/R X-Received: by 10.14.119.136 with SMTP id n8mr298399eeh.82.1384940997541; Wed, 20 Nov 2013 01:49:57 -0800 (PST) Received: from [10.16.0.189] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id a51sm57687397eeh.8.2013.11.20.01.49.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Nov 2013 01:49:56 -0800 (PST) Message-ID: <528C85C3.3070607@6wind.com> Date: Wed, 20 Nov 2013 10:49:55 +0100 From: Ivan Boule User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130922 Icedove/17.0.9 MIME-Version: 1.0 To: Maxime Leroy References: <1384866215-18420-1-git-send-email-maxime.leroy@6wind.com> In-Reply-To: <1384866215-18420-1-git-send-email-maxime.leroy@6wind.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/2] igb/ixgbe: ETH_MQ_RX_NONE should disable RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Nov 2013 09:49:05 -0000 On 11/19/2013 02:03 PM, Maxime Leroy wrote: > As explained in rte_ethdev.h, ETH_MQ_RX_NONE allows to not choose > between RSS, DCB > or VMDQ modes for the selection of a rx queue. > > But the igb/ixgbe code always silently selects the RSS mode with > ETH_MQ_RX_NONE. This patch > fixes this incoherence between the API and the implementation. > > Signed-off-by: Maxime Leroy > --- > lib/librte_pmd_e1000/igb_rxtx.c | 4 ++-- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_pmd_e1000/igb_rxtx.c > b/lib/librte_pmd_e1000/igb_rxtx.c > index f785d9f..641ceea 100644 > --- a/lib/librte_pmd_e1000/igb_rxtx.c > +++ b/lib/librte_pmd_e1000/igb_rxtx.c > @@ -1745,8 +1745,6 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) > */ > if (dev->data->nb_rx_queues > 1) > switch (dev->data->dev_conf.rxmode.mq_mode) { > - case ETH_MQ_RX_NONE: > - /* if mq_mode not assign, we use rss mode.*/ > case ETH_MQ_RX_RSS: > igb_rss_configure(dev); > break; > @@ -1754,6 +1752,8 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) > /*Configure general VMDQ only RX parameters*/ > igb_vmdq_rx_hw_configure(dev); > break; > + case ETH_MQ_RX_NONE: > + /* if mq_mode is none, disable rss mode.*/ > default: > igb_rss_disable(dev); > break; > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > index 0f7be95..e1b90f9 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -3217,8 +3217,6 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) > */ > if (dev->data->nb_rx_queues > 1) > switch (dev->data->dev_conf.rxmode.mq_mode) { > - case ETH_MQ_RX_NONE: > - /* if mq_mode not assign, we use rss mode.*/ > case ETH_MQ_RX_RSS: > ixgbe_rss_configure(dev); > break; > @@ -3231,6 +3229,8 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev) > ixgbe_vmdq_rx_hw_configure(dev); > break; > > + case ETH_MQ_RX_NONE: > + /* if mq_mode is none, disable rss mode.*/ > default: ixgbe_rss_disable(dev); > } > else Acked by Ivan Boule -- Ivan Boule 6WIND Development Engineer