From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m13-151.163.com (m13-151.163.com [220.181.13.151]) by dpdk.org (Postfix) with ESMTP id 2816B5B3C for ; Fri, 9 Mar 2018 13:14:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=w6XuG EmjZJFVeGLxT6zoMHLorCUw0YPI6MPVeINyxto=; b=QevX5PtRimIevq3pgML5H ey0oFnMdU7rumoBul8PJ0lvOH1rKjNWhh4G+kL1JJq8oJ3KOJHUr2RJH7KcV5Mlm 5A6NBdQDfEGEPRxE39cesWqlhsql9ScTdN2UydA7Yh6qIymfjtVmNzPjZbcydYA3 8bb+Nm9NjQdon/xV1CreF0= Received: from chaoys155$163.com ( [113.87.162.39] ) by ajax-webmail-wmsvr151 (Coremail) ; Fri, 9 Mar 2018 20:14:20 +0800 (CST) X-Originating-IP: [113.87.162.39] Date: Fri, 9 Mar 2018 20:14:20 +0800 (CST) From: cys To: dev , "ferruh.yigit" X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2018 www.mailtech.cn 163com MIME-Version: 1.0 Message-ID: <528c4b67.fc.1620aaef223.Coremail.chaoys155@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: l8GowAAHD6uceqJaXaWiAA--.10156W X-CM-SenderInfo: 5fkd05jvrvkqqrwthudrp/xtbBzRAEqFO-6xgQdAABsL X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] kni: continuous memory restriction ? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 12:14:27 -0000 Q29tbWl0IDg0NTEyNjllNmQ3YmE3NTAxNzIzZmUyZWZkMCBzYWlkICJyZW1vdmUgY29udGludW91 cyBtZW1vcnkgcmVzdHJpY3Rpb24iOwpodHRwOi8vZHBkay5vcmcvYnJvd3NlL2RwZGsvY29tbWl0 L2xpYi9saWJydGVfZWFsL2xpbnV4YXBwL2tuaS9rbmlfbmV0LmM/aWQ9ODQ1MTI2OWU2ZDdiYTc1 MDE3MjNmZTJlZmQwNTc0NTAxMDI5NWJhYwpGb3IgY2hhaW5lZCBtYnVmcyhuYl9zZWdzID4gMSks IGZ1bmN0aW9uIHZhMnBhIHVzZSB0aGUgb2Zmc2V0IG9mIHByZXZpb3VzIG1idWYgdG8gY2FsY3Vs YXRlIHBoeXNpY2FsIGFkZHJlc3Mgb2YgbmV4dCBtYnVmLgpTbyBhbnl3aGVyZSBndWFyYW50ZSB0 aGF0IGFsbCBtYnVmcyBoYXZlIHRoZSBzYW1lIG9mZnNldCAoYnVmX2FkZHIgLSBidWZfcGh5c2Fk ZHIpID8KT3IgaGF2ZSBJIG1pc3VuZGVyc3Rvb2QgY2hhaW5lZCBtYnVmcz8KCg== >From nhorman@tuxdriver.com Fri Mar 9 13:37:42 2018 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 3321D5B3C for ; Fri, 9 Mar 2018 13:37:42 +0100 (CET) Received: from cpe-2606-a000-111b-40b7-640c-26a-4e16-9225.dyn6.twc.com ([2606:a000:111b:40b7:640c:26a:4e16:9225] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1euHH1-0007W9-Gw; Fri, 09 Mar 2018 07:37:35 -0500 Date: Fri, 9 Mar 2018 07:36:51 -0500 From: Neil Horman To: Ferruh Yigit Cc: John McNamara , Marko Kovacevic , Thomas Monjalon , dev@dpdk.org Message-ID: <20180309123651.GB19004@hmswarspite.think-freely.org> References: <20180117215802.90809-2-ferruh.yigit@intel.com> <20180309112531.292163-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180309112531.292163-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [PATCH v4] ethdev: return named opaque type instead of void pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2018 12:37:42 -0000 On Fri, Mar 09, 2018 at 11:25:31AM +0000, Ferruh Yigit wrote: > "struct rte_eth_rxtx_callback" is defined as internal data structure and > used as named opaque type. > > So the functions that are adding callbacks can return objects in this > type instead of void pointer. > > Signed-off-by: Ferruh Yigit > Acked-by: Stephen Hemminger > --- > v2: > * keep using struct * in parameters, instead add callback functions > return struct rte_eth_rxtx_callback pointer. > > v4: > * Remove deprecation notice. LIBABIVER already increased in this release > --- > doc/guides/rel_notes/deprecation.rst | 7 ------- > lib/librte_ether/rte_ethdev.c | 6 +++--- > lib/librte_ether/rte_ethdev.h | 13 ++++++++----- > 3 files changed, 11 insertions(+), 15 deletions(-) > This doesn't quite make sense to me. If rte_eth_rxtx_callback is defined as an internal data structure, then it shouldn't be used as part of the prototype for an exported function, as the structure will then no longer be a internal data structure, but rather part of the public ABI. Neil