From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 56AB08DAA for <dev@dpdk.org>; Tue, 3 Nov 2015 14:56:44 +0100 (CET) Received: by wicll6 with SMTP id ll6so70170086wic.0 for <dev@dpdk.org>; Tue, 03 Nov 2015 05:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=w5JXKxmZNGkzKr/nS8PdlwynV01J2IMhVXPnLSDgA4w=; b=10CWwM0YZFafKlcraVdN77MxKGWv+rN9EAVKuKwxqJAsC0xOcWX5EpFwst911qx2BQ QzVLlCJARBhPzHSaBDXu/faFDMcjR8yxRozJhCNP0pec7b1QaUeebJ24czp6M1CYVil5 noV0GshyiC1SncbPO4TzRo66aY9WnCDVK2wciikCwyNGu4BP8cwJ3qVrwEw/j09PKHhe UZrcjLS6NCGhJWbYq28KqN13TcSjxebjvof7CHvpQx6OUu8SZ6W5jzBqV8Q8lgduVLhC FEVC3GYAfHP7DX7x6Cbam5HGquqEbbHmr9gRVjHF5WFLY8lo+DpbdMfTScO9uOwdJ0Dy C99A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=w5JXKxmZNGkzKr/nS8PdlwynV01J2IMhVXPnLSDgA4w=; b=i0xQg+Rwj+U3CBiHRI8fcuvq1U3YpizdDje9583eJ4MvZMvlQLhbYcrdbh16wGAWZA 1YQucF/WR9UMobMHmSq/H0uTgLx+ep6MQWJtGdR16S6bbtxiB5IsVtCovn9/3b6rcWdA Wq0YyaI3lVRrkz0OSkzSQKuXhVcfS9qihSueAHjdss6Lz0c98jxIhoQelh/mXzs5My0K /sn4bdtGOpIWdDULoylXW7ADCepJpkOo0c+0/6FIAXpBVzm8kNoAeSmRGCSTwXCnGJ43 jAJtGKkkLV8CVus0w4E8E/hV8o9saDDVlnU7g3qBloREr8Hy2q6C7UnA6Il6RMk7QnCq GmSA== X-Gm-Message-State: ALoCoQnalAHAhAGbY61SOgrc3mA3w8nqkabnX26K2GopqopwyAkGo4Bvz8V/2/vJWlVRs0eJEoWP X-Received: by 10.194.57.8 with SMTP id e8mr34290783wjq.32.1446559004208; Tue, 03 Nov 2015 05:56:44 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id s127sm23508126wmb.8.2015.11.03.05.56.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2015 05:56:43 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Tahhan, Maryam" <maryam.tahhan@intel.com> Date: Tue, 03 Nov 2015 14:55:33 +0100 Message-ID: <5290737.oElNeekJhY@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536A5E618C@IRSMSX109.ger.corp.intel.com> References: <1445257253-3673-1-git-send-email-maryam.tahhan@intel.com> <3108772.cu7MlmvWl0@xps13> <1A27633A6DA49C4A92FCD5D4312DBF536A5E618C@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/1] ethdev: distinguish between drop and error stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 03 Nov 2015 13:56:44 -0000 2015-11-03 13:14, Tahhan, Maryam: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > There was not a lot of comments on this proposal. > > If the idea is well received, it needs to be implemented in drivers, at least few > > of them. > > Hi Thomas > I was waiting to implement it across the drivers when I knew it was going to be merged to master. It shouldn't break anything that's currently using ethdev stats and should be relatively straight forward to implement for the drivers. Does it makes sense to add it into drivers now or wait for the next open DPDK window? It's better to change API only when it is used by some drivers. We can wait the release 2.3 to integrate it.