From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEBB8A04FD; Thu, 10 Nov 2022 10:42:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAE42400EF; Thu, 10 Nov 2022 10:42:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9A44840156 for ; Thu, 10 Nov 2022 10:42:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668073343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=muX0pgkvOoq5/0dpjd4vCcDjNFZQfdUTvKG3dJtdf7Q=; b=IVmeJVADw9zjNtLjZxb+/KnzoBam3wbEZ0NVWzRpp2JItDulxy2ANn8edmrjS1R5QryDXE TBaZppYbGFg6E7Z08BLX9bHZWwCWEfrD0U4ThhlIjUXttBfa6SPh9rkLgDRNyx6n6RX4kx 4IagV3Ei/cJLKArgj+V7j8nT60C24Rc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-493-iS0zfjzvO8S-qSNr6DDx-w-1; Thu, 10 Nov 2022 04:42:16 -0500 X-MC-Unique: iS0zfjzvO8S-qSNr6DDx-w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8EB063C0ED43; Thu, 10 Nov 2022 09:42:15 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E25A4C1908A; Thu, 10 Nov 2022 09:42:13 +0000 (UTC) Message-ID: <529277ff-9e3e-15e9-d969-3fd68d66378e@redhat.com> Date: Thu, 10 Nov 2022 10:42:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling To: Ali Alnubani , Taekyung Kim , "NBU-Contact-Thomas Monjalon (EXTERNAL)" Cc: "dev@dpdk.org" , "Pei, Andy" , "stable@dpdk.org" , "Wang, Xiao W" , "Xia, Chenbo" References: <20221108085624.53989-1-kim.tae.kyung@navercorp.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/10/22 10:34, Ali Alnubani wrote: >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, November 10, 2022 11:20 AM >> To: Taekyung Kim ; NBU-Contact-Thomas >> Monjalon (EXTERNAL) ; Ali Alnubani >> >> Cc: dev@dpdk.org; Pei, Andy ; stable@dpdk.org; >> Wang, Xiao W ; Xia, Chenbo >> >> Subject: Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling >> >> Hi Taekyung, >> >> Adding Thomas and Ali who maintains the patchwork instance. >> >> On 11/10/22 05:02, Taekyung Kim wrote: >>> On Thu, Nov 10, 2022 at 01:53:50AM +0000, Xia, Chenbo wrote: >>>> Hi Kim, >>>> >>>>> -----Original Message----- >>>>> From: Taekyung Kim >>>>> Sent: Tuesday, November 8, 2022 4:56 PM >>>>> To: dev@dpdk.org >>>>> Cc: Xia, Chenbo ; Pei, Andy >> ; >>>>> kim.tae.kyung@navercorp.com; maxime.coquelin@redhat.com; >> stable@dpdk.org; >>>>> Wang, Xiao W >>>>> Subject: [PATCH v4] vdpa/ifc: fix update_datapath error handling >>>>> >>>>> Stop and return the error code when update_datapath fails. >>>>> update_datapath prepares resources for the vdpa device. >>>>> The driver should not perform any further actions >>>>> if update_datapath returns an error. >>>>> >>>>> Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Taekyung Kim >>>>> --- >>>>> v4: >>>>> * Add rte_vdpa_unregister_device in ifcvf_pci_probe >>>>> >>>>> v3: >>>>> * Fix coding style >>>>> >>>>> v2: >>>>> * Revert the prepared resources before returning an error >>>>> * Rebase to 22.11 rc2 >>>>> * Add fixes and cc for backport >>>>> >>>>> --- >>>>> drivers/vdpa/ifc/ifcvf_vdpa.c | 27 +++++++++++++++++++++++---- >>>>> 1 file changed, 23 insertions(+), 4 deletions(-) >>>> >>>> I can't find your patch in patchwork: >>>> >>>> >> http://patchwork.dpdk.org/project/dpdk/list/?series=&submitter=2877&sta >> te=*&q=&archive=both&delegate= >>>> >>>> so it's difficult to review and merge. Do you know why or is it possible >>>> that you send a new version to make it show on Patchwork today? >>>> >>>> Thanks, >>>> Chenbo >>>> >>> >>> Hi Chenbo, >>> >>> First, thanks for your review. >>> I will send a new version for this patch soon. >>> >>> I think the mail for v4 is lost. >>> Whenever I send a patch, I received "Your message to dev awaits >> moderator approval" >>> from dev-owner@dpdk.org with the reason "Post by non-member to a >> members-only list". >>> Maybe, the reason is that this is the first time that I submit a patch. >> >> No, I don't think subscription is needed, there should be another issue. >> Ali & Thomas, any idea why it happens? >> > > Hello, > > Subscription to the dev mailing list is required for posting without moderator approval. > I see that Taekyung is a member only since Nov 08. Postings prior to his subscription are waiting moderation. Ok, thanks. I did not know! Maxime > Thanks, > Ali