From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A65664A63 for ; Fri, 15 Dec 2017 11:32:13 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 37C0720BE5; Fri, 15 Dec 2017 05:32:13 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 15 Dec 2017 05:32:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=in1Q7HSoZo+ULztSAqHhp5Ryly DL89h3DEQWcx6z838=; b=VZSMV/gWi0B5XGDYMlyKmW9lJe0dQN7khXC7aN00fH xU1ZY0S+gkAtrT4C/0ME1iX+6rw1q6WNlDClNT83biEEu0wjgHMpLLckB71ZC4jQ s7LhVLL0/bIpdWwl/JKzwcdZqxSD8yMjCGCuYB1JTEoqCdGHwZpwh1kMdzjeOazj 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=in1Q7H SoZo+ULztSAqHhp5RylyDL89h3DEQWcx6z838=; b=H1pmiuWBNsHICcAmJiBdzD Si3EAtDWWun5viv99Gn6XSbZqefGPgFXMlex5OFV5GmOYHng7iphdIkvFd8wQm/g l6nvXOQckFJjhQ24f8PSqwPjtPE7FPQRmLnbNjDVOEC7UrJcFNek+PvKz6m3QZhz u5ML9vradU4odMP0zq08Pfds7sznx/EpQMURlV3/cvaFpbyUpKq1/HhMv7mhnsq7 jXCjGIxxyx8FjLVzddI5mTafzTsqVRcK2d60r+9dno7dX92H3o6TN9PyqDHMDhax R0JXP769claGwPN9anC6nk07gWKrFhXtaIwTpHnH3jzgptdFmJGG8ZWDj2M8yZ7w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DE94E24211; Fri, 15 Dec 2017 05:32:12 -0500 (EST) From: Thomas Monjalon To: Olivier MATZ Cc: dev@dpdk.org, Samuel Gauthier Date: Fri, 15 Dec 2017 11:32:12 +0100 Message-ID: <5295568.lEBEY0ou7Q@xps> In-Reply-To: <20171215102516.ltn5uhrglvvnb66e@platinum> References: <20171214142411.25375-1-olivier.matz@6wind.com> <7350468.cg4rjIInEc@xps> <20171215102516.ltn5uhrglvvnb66e@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: fix libs installation when installing sdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2017 10:32:13 -0000 15/12/2017 11:25, Olivier MATZ: > On Fri, Dec 15, 2017 at 11:19:57AM +0100, Thomas Monjalon wrote: > > 14/12/2017 15:24, Olivier Matz: > > > @@ -157,6 +157,8 @@ install-sdk: > > > $(Q)cp -a $O/.config $(DESTDIR)$(targetdir) > > > $(Q)cp -a $O/app/dpdk-pmdinfogen $(DESTDIR)$(targetdir)/app > > > $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include) > > > + $(Q)$(call rte_mkdir, $(DESTDIR)$(libdir)) > > > + $(Q)cp -a $O/lib/* $(DESTDIR)$(libdir) > > > $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib) > > > > The libs are already installed with "make install-runtime". > > Either we add a dependency between install-sdk and install-runtime, > > or we clearly document it. > > To me, libs are needed when installing the sdk (to compile against them) > and when installing the runtime (to use them). > > Is it a problem to have it in both targets? Yes it is a problem because the general use is to call every targets, so the libs will be installed twice. Look at the global "install" target. Do you want to be able to install the SDK without the runtime?