From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E90F743B4B;
Mon, 19 Feb 2024 10:33:22 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D78F54067C;
Mon, 19 Feb 2024 10:33:22 +0100 (CET)
Received: from NAM04-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam04on2088.outbound.protection.outlook.com [40.107.102.88])
by mails.dpdk.org (Postfix) with ESMTP id 93D9940289;
Mon, 19 Feb 2024 10:33:21 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=DGQhnoH4j3je2ffJFk3KIA1VjWVVs29TijX6JC18N6nqemD41xHj+JeoZvDTDl2qOH2Vkz9aAOagx0w/vJyvW/7yUASSMgS5e0IEyQWDdqxDonW6mHxs24Vnm6AoPV1afsszMJSXKXz9IPy2u4nuw6gRuQBeZch3ooF+rCuyj+6la7hBRv/QR8tPNdKBLvMx/0lAyguncBAQ6G+cuF38np9rBpN3KflMUk4jbVAFiLY8RIpgoFENpQ7g5f6MldooJR5BGhQPhraz17zOaA7HRjyOJ/gAzguU05GvO7sShnxiCVzg7OWiwknfCL0ynDntYnvoIG8xwbYQHzy2PldZcQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=U2hE/5wTA2ywVesLpuKXGsQJeDucssRfuxlTR+fLBsY=;
b=jh//PT0ED2W5GH3vPZmzPVJtgwBXdQrMTdlUoz/yjojas1aJ2mt16VIsRHTLcgztWumk6vqj5Qdimeb0cz2ze62fAoqga3OilP1U6XV3rLDvqfs/jfj2/n7uJiIHFu6414ocrzg/kQ2efKJL8Kab8pUDKe9rfrz7k3kF1bVMG4Lg+ay0J+dVJKDj+wXBP2gvpIsEgr98JHLmZtXSETw1kJmManjC0Bgw4xw16TYSQpYC+DneQAR+ZK3eYixoH10TTDUIAqXWGBGHPvAqSeAdlpYmsx/c6Xfl3YdFHP+vfl8MR4leVEMps8A0YkUxnD6EzTnFAan3zONCzR40FHjT/Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=U2hE/5wTA2ywVesLpuKXGsQJeDucssRfuxlTR+fLBsY=;
b=J4SEVJeLvvj5if0Kefc3gh2XKOtCK7TO9gPSh8YPo+tlwJ0Fr5LPwTXlw15dTtsoneWsfVIcwYSIlGQfy1B+BKPvczRLSUDGfRqqrmWSkotIZe6qDSRVsNmoaVa4zmCDbNphY5n242JolwLfuxdhCOEqtktCFP2TT4u5hQX3O5Y=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=amd.com;
Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)
by MW6PR12MB8867.namprd12.prod.outlook.com (2603:10b6:303:249::6)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.19; Mon, 19 Feb
2024 09:33:19 +0000
Received: from CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com
([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.018; Mon, 19 Feb 2024
09:33:18 +0000
Message-ID: <5295dc14-7b01-4855-86b5-6039adbdac1c@amd.com>
Date: Mon, 19 Feb 2024 09:33:14 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] net/gve: Change ERR to DEBUG to prevent flooding of logs
for Tx-Dqo.
To: Rushil Gupta <rushilg@google.com>, junfeng.guo@intel.com,
jeroendb@google.com, joshwash@google.com
Cc: dev@dpdk.org, stable@dpdk.org
References: <20240219024436.1010010-1-rushilg@google.com>
Content-Language: en-US
From: Ferruh Yigit <ferruh.yigit@amd.com>
Autocrypt: addr=ferruh.yigit@amd.com; keydata=
xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9
4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J
eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg
B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9
RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ
N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ
vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S
3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum
CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA
XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln
aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID
AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK
Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3
tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU
58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs
cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD
VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg
Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc
GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV
gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW
VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD
DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG
CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe
WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi
6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl
90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv
VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA
fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr
ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC
IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk
1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak
oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq
b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ
Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX
W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW
honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA
g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn
GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ
NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs
SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe
cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH
dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk=
In-Reply-To: <20240219024436.1010010-1-rushilg@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: LO4P265CA0153.GBRP265.PROD.OUTLOOK.COM
(2603:10a6:600:2c7::16) To CH2PR12MB4294.namprd12.prod.outlook.com
(2603:10b6:610:a9::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW6PR12MB8867:EE_
X-MS-Office365-Filtering-Correlation-Id: 03454612-7c1c-4378-a22d-08dc312dce5d
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: vwQK0luqnO+ZXB1KVAP0iGo9DfO5PUlByVgpCWDjqyoqQxz93L8V+5/jmGgN+B/f02JZK7yYz7nTICf9+H01buzGzXEiqMyaPn4LqfRlBIqSFUYXzr7yDE+gacpHWTixmD1y6UHeGk6psyqZ4wtH4vC4tlhlfFN3HkVekc4lw0w6hr2kf8ppccDjRFKYi2Bd3jOUcekz8q/ftYJNj6i4ey5heUD7xFJIOoGkdGbRVj0NTubik5sNzekBj6uHChbYKEoULzjgg16MrNGfaLrl4/fAGxk/CcsSGHFA4bbPFq/XKNgY9BPd7UZXYfwRIYD6YjO0db4gT2Wj2Vl/yfydFMoi+bKA0B7KkNdLqHywWi2IJSE4rm8PwA6mqdM+rH+v4gvIdP6/WNcQ0gVgkuXtmY2MD9Lz8AvQWUmkV4lxCTWKA7Y0ayN6kJ0cXgq7Kju98KsGF0ITu2OJ9XVg40Pu/OVjbFsUtVVXfax+QtKhVVnbXhxXmOtcZg8hB+CyQAaIuUbcbYjfYwzT0bwjXfWWqtiCx8Wu+2/AM9bMw+SPb4t8c0M9n1D1dsLxBH/3RQHG
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230031)(39860400002)(136003)(396003)(366004)(346002)(376002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(316002)(86362001)(31696002)(38100700002)(2616005)(36756003)(26005)(2906002)(31686004)(5660300002)(44832011)(6666004)(41300700001)(6512007)(8676002)(8936002)(4326008)(66946007)(66476007)(66556008)(478600001)(53546011)(83380400001)(6506007)(6486002);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1VNU2FaYkljRjFvaVVKWmQvUTBGU1Vva0liT0s1SnZ2U2JvaFFMajdCVWU3?=
=?utf-8?B?WGpvN3NtY2xWWnZsQ1UvTWJPUHYyY3hyZDIzM1BCSlM5K01XUkVXQzZhTmQ1?=
=?utf-8?B?K1FrVG5Cek5FeHlubVZpc3NmZTJtVVN5UVFoaVhVMGErUGZaSmRYZ0dRWStu?=
=?utf-8?B?QmxoU1VRQTFJS3BoaDg3TU8xTVNPd2hSSnI2QzZkOVd2NXJtR3dZc0htQ0k4?=
=?utf-8?B?Q20zdlBjVUFBWUo2RVBpTnN4TkNQU3ZES0hLMDlUZy9HcnhMWmI1d04xS1Qw?=
=?utf-8?B?MzUvMGM1N0sxNm90ZEp5NTYxV3NZZGVSdUoyM2duazJHcWZSVGE2SjJoQ1Zt?=
=?utf-8?B?RzhFWjNMc0dDZE96YmkzT2JuSmJQTGFrWnNYVHlxOVFWRy9Od09CS3V0VC8x?=
=?utf-8?B?T1p6bGlSRmw1cm5vT1JjM05IRE9LbXhHTStQSU5md0dEUEF4Z1liOCtjMVZE?=
=?utf-8?B?U2hnRHk5eEQrZ29hUnRTUW9BeWhJaGZTOVlIbFdlb2NER1FKMUxzaDI2TjU2?=
=?utf-8?B?cUF0RGZlOVlVOHltWEN0Sng3Z2ZuZzdiRUM2dVVJYzI5Wml3WFNLZkRrdlpm?=
=?utf-8?B?WWMzUkhTRTJVOHh4QWpqK3I4ZmN0TldVSnIxSEVnQktDaXFtaUphcm9DR1Vq?=
=?utf-8?B?QS9DWHU4cjAwVmZXT0lFRXJwbzRYNURuTGo3NnVhdG83RVlGVUNSQVZqMVAy?=
=?utf-8?B?SVBWNWZ1R3JjaTJ6bjBKS1lEeEYxNTU2S3FjSlpiVG5Db2JBSnZ6VnBzZlpx?=
=?utf-8?B?MEQ2ZUdkaHd6Nkx2YjFWeHhSSHFGZHZkNjkxc0FCNU1wYitzT084cEtDNHow?=
=?utf-8?B?WDc5VytPdU12enlkR2FXVmtrYnhGUnRnNlczRmlBVk1JanYwT2ltKytCYkRz?=
=?utf-8?B?d1dJRFhybTdUYm13UFpQRHlzUDFYQkxQcTRySHY4NWxTV1dsWkJsK084Rmo2?=
=?utf-8?B?VGEvRld2UzZBR1lNTUdPME5LeGx3RVc3SlNMb3ZZQWJjaUhXRkVJdHh2S1FP?=
=?utf-8?B?VUpLQUlBYTN1YUw3cUtUaVJVSndZZE16dGJDMTRLcE4rOFFKelNwRFBwWWdG?=
=?utf-8?B?Tjk4aEJkeHVHS3JpcmtqR1NSMSsvRmtoMVovSVRDdEllRk9SbkhEQTlQc3R4?=
=?utf-8?B?U0dPc2pRQU1ZUmR1a1oyMkx4TlJHOVZhQ2NVT0FlZWhUSWhCZVVSVVpqemdX?=
=?utf-8?B?aFI3VlBUc2w3Y2YzOHlpQjRJQzRHS0g0aUw5L1BiMWZ5dlg2ZXVmQkYvM3dx?=
=?utf-8?B?RVlEWHBSYVUzYVdiYmkvUVdaYStEZlJUa1ZKQ2RyamlTYk5NL090MndHUldR?=
=?utf-8?B?Kys2N2JRMlJGbzNQVmRBeHhrTlpydmVpYm9ZaU5rTm5SbkRUb0U1bnhveG9W?=
=?utf-8?B?bVdWRmh4blN3d0EzNkk5WnhXZEhsWE1zS2EyRXMzakZZN2NPd21EV2p6VFVu?=
=?utf-8?B?UThXR0hpZWtXMTVVc1BhTHFzTnMyZE55Y2lReU9kQU9weHBab1NiQVNYNlpY?=
=?utf-8?B?S2FCVE9oRTdjMzYySnl6UXNWUnhVYWNrT1h4SEU0ckVoTDh0ZFV6alRYTkVZ?=
=?utf-8?B?SXMvMUhRUDZPL09GbC9aRGMxVEZwVXl2ckNnUUg1Rm1PODIzQ1I5cTA3Z0hG?=
=?utf-8?B?b29CTmxQQlhEQkpveWhXV2JiN1U0YW5VYWptV1BRakw0Mk1DUkYxMXhBQ0Vk?=
=?utf-8?B?YzhMbmIxNGVkc0hPV2g1UlNSbUZET0x0cVdFakExZGVKV2tNSmQ3M0dPcVQv?=
=?utf-8?B?bjAycHNrb05HZ1VsQ0FkQXFVdGZwSkVpMEpndEVHczRKZU5VbVJWUy9GL1lC?=
=?utf-8?B?ZzBpTWoxeGI4Z3p3ZTFwVTdJUGpMSW9yK0ExaWlHWXpGSFZEaU0wMkJhRHN6?=
=?utf-8?B?b0FJRzFBY05PaDd5ZTJONllwL2tDanR6eU9RYzhDYUxiZTE3bTBuRHhtU1pq?=
=?utf-8?B?T25RbHBQaWFLNFdqUWZpMFhKaUxTUi9TR0NGZTMrMkdTWjhoKzJiWDVCZmxH?=
=?utf-8?B?YU9RSHBMMzZvVmRYMi95NVpQS0tkMFlqZTM0ZmR6enlSdzN4WGZONTRtZ2VM?=
=?utf-8?B?Q0N4cTRCcG00djN3UGtTenpUZ0ZCazZpUnlSdmtXU2cxMk5mdlZtcTlSaUFN?=
=?utf-8?Q?Gr8/s6OU7DS+91Vd9LbbyClx/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03454612-7c1c-4378-a22d-08dc312dce5d
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 09:33:18.7481 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w6cPzQoU2XW4yOZp15dYTe9DBoxkaPR7gIdYZfNedA0D/X4gQbIQlESg02ZqDez6
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8867
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 2/19/2024 2:44 AM, Rushil Gupta wrote:
> This was causing failure for testpmd runs (for queues >=15)
> presumably due to flooding of logs due to descriptor ring being
> overwritten.
>
> Fixes: a01854 ("net/gve: fix dqo bug for chained descriptors")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rushil Gupta <rushilg@google.com>
> Reviewed-by: Joshua Washington <joshwash@google.com>
> ---
> drivers/net/gve/gve_tx_dqo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c
> index 1a8eb96ea9..30a1455b20 100644
> --- a/drivers/net/gve/gve_tx_dqo.c
> +++ b/drivers/net/gve/gve_tx_dqo.c
> @@ -116,7 +116,7 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
> first_sw_id = sw_id;
> do {
> if (sw_ring[sw_id] != NULL)
> - PMD_DRV_LOG(ERR, "Overwriting an entry in sw_ring");
> + PMD_DRV_LOG(DEBUG, "Overwriting an entry in sw_ring");
>
> txd = &txr[tx_id];
> sw_ring[sw_id] = tx_pkt;
Hi Rushil,
I will continue with this patch, BUT
logging in the datapath has potential problems like this, also it may
have performance impact even log is not printed, because of additional
check in the log function.
For datapath, you can prefer:
- Add log macros controlled by RTE_ETHDEV_DEBUG_RX & RTE_ETHDEV_DEBUG_TX
flags
- Or use RTE_LOG_DP() macro which is compiled out if default log level
is less than the log uses
Also another perspective for the logs, when end-user observes this bloat
of logs, what she can do?
Can she change some driver arguments or environment variables to fix the
issue, if not what is the point of the log?
If this is a condition that can occur dynamically based on received
traffic and user doesn't have control on it, maybe driver should handle
the error without log?
And if this is a log for driver developer, perhaps it should be assert
or similar that is disabled in the release build?