From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57EE3A0487 for <public@inbox.dpdk.org>; Tue, 30 Jul 2019 09:11:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E99E1BF54; Tue, 30 Jul 2019 09:11:14 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 300571BF43 for <dev@dpdk.org>; Tue, 30 Jul 2019 09:11:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C6C1F20B0D; Tue, 30 Jul 2019 03:11:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 30 Jul 2019 03:11:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=al/pp4XL+KuZQOn/0NKj9R3ZBsFBU6iWOm15QqW+pC0=; b=kMJP+3bjFn8j w/F/wRFcgIm9R0pTShK87f5ruxGoBgqm4XDvVhR3uS3jnWaTjehqaZupWfa5c6iv Bs5IP3IcySKTyofkhlsFxZ8frVdzi2Km+dpp/rxIo6zLCw/9zceikA0Kl9kEoitO GwuYDGn15W9PA11aSuvSJ+xr0TFL9pU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=al/pp4XL+KuZQOn/0NKj9R3ZBsFBU6iWOm15QqW+p C0=; b=X7vRjWW4nUbilPcrREK1cq3AAA1yiBaadDapcRO6nd/RdkVHcNB+xKFPE 5DK0vk5Fv/M2xS0eD/1FPEnsgHTXcmzUjueHlGZqWyPrAoXuIBTh47qwP1G5payg YWq3/6uCamtjl5xfepJBmlgRza3yfvzDyNw1e+ZR5Ep3FB54K3u6V3JV4dVoRZpp NfeljAWjV+wrZT1Xa//ds+/UQPcXuW0ogSmY989JrKPpgcLjmEcPXKclB9DXadQ1 nltTACVFo/ldfg1zavOkka1s4UT93kfdqbpugsQ3kCijjZa016r5/n6FtQhvCMO5 fWgxdz0NeA8ureIGD4C7SpZttDmSw== X-ME-Sender: <xms:kO0_XbR2MwVYegapTjlhmJfXg4WdafdjrOOj7hO4Y43f1ihomwweyQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrledvgdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:kO0_XSQ53qFm3DCuYqpS9rJZipb4xxYOY1eie_YXK-V2dvv5dkrCrw> <xmx:kO0_XTgWp5KC_U8wFasMV-0tUG_lQBnGu9UdCKHHqZG53JDtoMJUtA> <xmx:kO0_XYZF6ZqdlrGD0xn3hs8RfmtNJy4vC6eUR1aYr1fiFQNT4FV7bA> <xmx:kO0_XQriAyLViy7Xq1raMBm6P4inhUhjaQkLrJUWceYpWl5PWLVoqA> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F1EF580059; Tue, 30 Jul 2019 03:11:10 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Harman Kalra <hkalra@marvell.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, John McNamara <john.mcnamara@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>, Bruce Richardson <bruce.richardson@intel.com>, Harry van Haaren <harry.van.haaren@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>, "barbette@kth.se" <barbette@kth.se>, Yongseok Koh <yskoh@mellanox.com>, "viacheslavo@mellanox.com" <viacheslavo@mellanox.com> Date: Tue, 30 Jul 2019 09:11:10 +0200 Message-ID: <5296418.QIOJa9lHfJ@xps> In-Reply-To: <20190730065702.GA23822@outlook.office365.com> References: <1564069902-3500-1-git-send-email-hkalra@marvell.com> <2174860.Ph4OkxdjrP@xps> <20190730065702.GA23822@outlook.office365.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] examples/rxtx_callbacks: fix HW timestamp enable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 30/07/2019 08:57, Harman Kalra: > On Tue, Jul 30, 2019 at 12:18:59AM +0200, Thomas Monjalon wrote: > > External Email > > > > ---------------------------------------------------------------------- > > 25/07/2019 17:51, Harman Kalra: > > > Offloafing Rx timestamp is a device capability than queue capability. > > > > Why is it a device capability and not a queue capability? > > 1. Since all PMDs doesn't implements per queue offload capabilities but > supports RX timestamping and also since rx_offload_capa includes all > rx_queue_offload_capa's. So we moved the DEV_RX_OFFLOAD_TIMESTAMP > configuration setting to device from queue, as its a test application > and should work with all PMDs. > > 2. Or we can have a test in this application, i.e. if PMD has > rx_queue_offload_capa implemented go with per queue configuration else > make it a device configuration. > > If OK with this first approach, we will send V2 with reworded commit message > explaining the reason as above. I'm fine with any logic if 1/ it works with all PMDs 2/ the real reason is explained