From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7DF50A04FA;
Thu, 6 Feb 2020 01:56:13 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 678CE1C223;
Thu, 6 Feb 2020 01:56:12 +0100 (CET)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id 0D5501C21B
for <dev@dpdk.org>; Thu, 6 Feb 2020 01:56:10 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
05 Feb 2020 16:56:09 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.70,407,1574150400";
d="scan'208,217";a="344241329"
Received: from unknown (HELO [10.241.225.211]) ([10.241.225.211])
by fmsmga001.fm.intel.com with ESMTP; 05 Feb 2020 16:56:09 -0800
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net, Harini.Ramakrishnan@microsoft.com,
keith.wiles@intel.com, bruce.richardson@intel.com,
david.marchand@redhat.com, jerinjacobk@gmail.com, ranjit.menon@intel.com,
antara.ganesh.kolar@intel.com
References: <20200131000307.10608-1-pallavi.kadam@intel.com>
<20200201000406.11060-1-pallavi.kadam@intel.com>
<20200201000406.11060-6-pallavi.kadam@intel.com>
<20200205230422.587934de@Sovereign>
From: Pallavi Kadam <pallavi.kadam@intel.com>
Message-ID: <52f55d65-92c4-96bf-bd88-057699c4c980@intel.com>
Date: Wed, 5 Feb 2020 16:56:08 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <20200205230422.587934de@Sovereign>
Content-Language: en-US
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v7 5/9] eal: add function to detect process
type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 2/5/2020 12:04 PM, Dmitry Kozlyuk wrote:
>> +/* Detect if we are a primary or a secondary process */
>> +enum rte_proc_type_t
>> +eal_proc_type_detect(void)
>> +{
> [...]
>> + OVERLAPPED sOverlapped = { 0 };
>> + sOverlapped.Offset = sizeof(*rte_config.mem_config);
>> + sOverlapped.OffsetHigh = 0;
>> +
>> + HANDLE hWinFileHandle = (HANDLE)_get_osfhandle(mem_cfg_fd);
> [...]
>
> Identifiers don't follow naming conventions.
Thank you, will fix this in v8.
>