From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B503A04E6; Fri, 30 Oct 2020 18:53:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FB7D3253; Fri, 30 Oct 2020 18:53:27 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7CC0F2C2A; Fri, 30 Oct 2020 18:53:24 +0100 (CET) IronPort-SDR: usGezKSM+eJ8QINAflgFkyRVxO0njO5013io0a2tilj23a0ePtzOUxMwyY4n8XZLAeC255NF+M ZEY/UYBUEZqw== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="155619287" X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="155619287" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 10:53:21 -0700 IronPort-SDR: jILGDmsxPZ69eP5B5EinMJ9aame3sLmShsm7up3xm+FaSDnxJADYMeZBrteTUeROFn/ihk6V0Q 966d9F6y5xag== X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="537144735" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.23.197]) ([10.252.23.197]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 10:53:19 -0700 To: Hyong Youb Kim Cc: dev@dpdk.org, stable@dpdk.org, John Daley References: <20201030072749.29113-1-hyonkim@cisco.com> From: Ferruh Yigit Message-ID: <530c4fb0-8383-8f2e-02d3-dbb8fb758023@intel.com> Date: Fri, 30 Oct 2020 17:53:15 +0000 MIME-Version: 1.0 In-Reply-To: <20201030072749.29113-1-hyonkim@cisco.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/enic: fix header sizes when copying flow patterns X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/30/2020 7:27 AM, Hyong Youb Kim wrote: > Several functions use sizeof(struct rte_flow_item_eth) and > sizeof(struct rte_flow_item_ipv6) when copying headers. These sizes > used to coincide with the sizes of rte_ether_hdr and > rte_ipv6_hdr. But, with recently added fields, rte_flow_item_eth and > rte_flow_item_ipv6 have grown in size. Use sizeof(rte_ether_hdr) and > sizeof(rte_ipv6_hdr) instead. > > Coverity issue: 363572, 363573 > Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") > Cc: stable@dpdk.org > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley Applied to dpdk-next-net/main, thanks.