From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 2302C6AB1 for ; Sat, 1 Mar 2014 13:00:17 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1WJicx-0006SX-1c; Sat, 01 Mar 2014 13:02:49 +0100 Message-ID: <5311CC3E.1010804@6wind.com> Date: Sat, 01 Mar 2014 13:02:06 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Stephen Hemminger References: <1393608350-4431-1-git-send-email-olivier.matz@6wind.com> <1393608350-4431-3-git-send-email-olivier.matz@6wind.com> <20140228133929.03844b24@nehalam.linuxnetplumber.net> In-Reply-To: <20140228133929.03844b24@nehalam.linuxnetplumber.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 02/11] devices-args: introduce rte_devargs in eal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Mar 2014 12:00:17 -0000 Hi Stephen, On 02/28/2014 10:39 PM, Stephen Hemminger wrote: > Minor nit. please align case with switch(). > The DPDK in general follows Linux coding style. > In fact, I have run the code through checkpatch to find style issues. Thank you for reporting this. Following you comment, I launched checkpatch.pl on the all my patches and found some (minor) issues. I will submit new versions for them. Regards, Olivier