DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: Meir Tseitlin <mirots@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Pcap question
Date: Mon, 03 Mar 2014 22:31:38 +0100	[thread overview]
Message-ID: <5314F4BA.7020507@6wind.com> (raw)
In-Reply-To: <CA+Typ9kTXGfhs-t+NY+1A-Ui645JPKKSGkim9BjAU-h-d+xuNQ@mail.gmail.com>

Hi Meir,

On 03/03/2014 10:09 PM, Meir Tseitlin wrote:
> -Wl,-lrte_pmd_pcap -Wl,-L/usr/local/lib -Wl,-Wl,-rpath,/usr/local/lib
> -Wl,-lpcap

The problem is related to the lines above. They are generated in
rte.app.mk:

   ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
   LDLIBS += -lrte_pmd_pcap
   LIBPCAP_LDFLAGS ?= $(shell pcap-config --libs)
   $(if $(LIBPCAP_LDFLAGS),,$(error LIBPCAP_LDFLAGS is undefined))
   LDLIBS += $(LIBPCAP_LDFLAGS)
   endif

The output of "pcap-config --libs" on your computer is probably:
   -L/usr/local/lib -Wl,-rpath,/usr/local/lib -lpcap

The problem is that the DPDK makefile add the "-Wl," to convert the
linker arguments into gcc arguments. You may want to replace the
code above by:

   ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
   LDLIBS += -lrte_pmd_pcap
   repl := -Wl,%
   LIBPCAP_LDFLAGS ?= $(patsubst -Wl$(comma),%,$(shell pcap-config --libs))
   $(if $(LIBPCAP_LDFLAGS),,$(error LIBPCAP_LDFLAGS is undefined))
   LDLIBS += $(LIBPCAP_LDFLAGS)
   endif

I don't know if it's the proper way to fix this. Maybe rte.app.mk
should take care of not adding "-Wl," if it's already there.

Regards,
Olivier

  reply	other threads:[~2014-03-03 21:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-02 19:13 Meir Tseitlin
2014-03-02 20:11 ` Olivier MATZ
2014-03-03 19:31   ` Meir Tseitlin
2014-03-03 20:32     ` Olivier MATZ
2014-03-03 21:09       ` Meir Tseitlin
2014-03-03 21:31         ` Olivier MATZ [this message]
2014-03-03 21:37           ` Olivier MATZ
2014-03-03 21:45             ` Meir Tseitlin
2014-03-05 20:32               ` Meir Tseitlin
2014-03-06  9:00                 ` liljegren.mats2
2014-03-06  9:00                   ` [dpdk-dev] [PATCH] pcap: Remove check for pcap_sendpacket liljegren.mats2
2014-03-06 10:10                   ` [dpdk-dev] Pcap question David Marchand
2014-03-20 16:38               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5314F4BA.7020507@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=mirots@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).