From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 1E7935908 for ; Tue, 4 Mar 2014 14:07:56 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id n12so681736wgh.0 for ; Tue, 04 Mar 2014 05:09:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=dL+rdccp0DoqtlvzaxmbJNjLgyZamrM7V/UWpM8Qf1A=; b=WRxa6DOIcjlKVVv4trXhAyU9Y1AHk0G5pYJMiUUMT3eJREsjJ7xIv18LSpgVyqsnnP Ko+anZY3c9vOFWwCqHlqPiwkMFMqwx97Gv66dNLjylkFdbMQKhOp7F3oB9wL2CxPX9Nc 1/sPL7ZhngTnTVuLTsdZJpM+qMNAQtj1hUAUOsM/oRAW7+htoVZ42tIM5la5eeNlKY/a Qxhc55HRFgKz8wyfNKy2gDclU/sBoPwiJvRgCYkGPlocJBDU4gOU/5m+2kDKna+hzgba Zsml5HbCBCLT7C/PJtgS6Vi/DOTpNeT7EPnXShlLkI/U6tZjIB7JN9f2kDHvf2AVYGYi 7uiQ== X-Gm-Message-State: ALoCoQlbJPY0M/vX+EML4ObHsjSWEHdbPB3zuugU7BjYGeoKrDVLrEWTiF+YrEW8s7ZlJ+ERqLoT X-Received: by 10.194.174.4 with SMTP id bo4mr16270858wjc.62.1393938564664; Tue, 04 Mar 2014 05:09:24 -0800 (PST) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id h13sm52413879wjr.22.2014.03.04.05.09.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Mar 2014 05:09:23 -0800 (PST) Message-ID: <5315D081.20506@6wind.com> Date: Tue, 04 Mar 2014 14:09:21 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: "Richardson, Bruce" References: <1393608350-4431-1-git-send-email-olivier.matz@6wind.com> <1393608350-4431-10-git-send-email-olivier.matz@6wind.com> <59AF69C657FD0841A61C55336867B5B01A9A16C7@IRSMSX103.ger.corp.intel.com> In-Reply-To: <59AF69C657FD0841A61C55336867B5B01A9A16C7@IRSMSX103.ger.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal option by pci-whitelist and vdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Mar 2014 13:07:57 -0000 Hi Bruce, On 03/03/2014 06:14 PM, Richardson, Bruce wrote: >> Subject: [dpdk-dev] [PATCH 09/11] device-args: replace use-device eal >> option by pci-whitelist and vdev >> > Reviewing the patch set, most of the changes make sense to me. This > one I've a few comments on. OK, thank you for your review. > Is it really necessary and beneficial to split the --use-device option > into two, and have two different ways for specifying the devices to > use, based on whether they are pci or virtual devices? An alternative > suggestion/idea: keep a common flag (be it --use-device, or something > else) to specify a device to use and that device's parameters, for all > device types, pretty much as now. Then, to solve the issue of not > being able to use blacklisting plus virtual devices, that could be > solved by adding the --pci-whitelist like you suggest, except instead > of specifying the devices there, it simply means that only the pci > devices passed to use-device get used. Without --pci-whitelist, all > pci devices get used, whether or not they are explicitly called out > with --use-device? My initial concern was that --use-device has 2 different significations, depending on the format of arguments: - instanciate a virtual driver if it looks like a vdev name - add a PCI device to the whitelist if it looks like a pci address I also find strange that instanciating a virtual device changes the PCI mode to whitelist, even if it could be fixed by adding a specific argument for that. Splitting into two different options looked clearer to me, but this is of course not a blocking issue for me. Regards, Olivier