From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1D8E95592 for ; Sun, 28 Oct 2018 22:19:01 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A2EBE21EDD; Sun, 28 Oct 2018 17:19:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 28 Oct 2018 17:19:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SYqWho9/1VbJ+QmJlHSxWj6ojAII0OVlb4mDOO9PelM=; b=f9Knq8QdOr9s w9OsUZhcpgu89CNLAwQfvsPdZy4oFLrRZJq007jLpIb7AstxOiN3DQO53Of44PGO 2ZwmRqSUp+BhcxAvbck1R9LCGs44FxrT5yYpyhxCSDR5tsmyiF2Kfy7ufbJJ53bS Tao4ziTdwKASP7h3y2Q3KDVvSdKaxWk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=SYqWho9/1VbJ+QmJlHSxWj6ojAII0OVlb4mDOO9Pe lM=; b=xuGjrpkb+xtqkrTAMOUwk++UT0VRsuZuVzuRUrUkfbmMHUzFNB6q0Fc9/ 9w9J2Vng1WdGA6HbsI0dpqjwIsQ+YFscdbhF8ia+i01gZPkHtcZT+RDhddklHdCr oJwlUx/MME2pCJPig/nocfU79n0KXwYQ9DKc4YrTK+kXbAJ7XQ4F/JNeLERsCGiY ZevLbq6bYFbF6V6AQ6sd28RX/IWh5FzIrn9sBdgJmD5MgqHN7c5jOd2zy5PuXAo9 aywiBya7k0Ff6Ng+GJ6/RiStIJzqCQoRKt9RltNOKCmKqPogzHOPH+mzcJEcNirp qvweGBI+8oTY8bQo6znGOaE+gzlbw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 714CE102E9; Sun, 28 Oct 2018 17:18:58 -0400 (EDT) From: Thomas Monjalon To: Cody Doucette Cc: dev@dpdk.org, Gaetan Rivet , "Ananyev, Konstantin" , Olivier Matz , "Dumitrescu, Cristian" , Michel Machado , "Fu, Qiaobin" Date: Sun, 28 Oct 2018 22:19:04 +0100 Message-ID: <5318192.uTAyPRLYMi@xps> In-Reply-To: References: <20180727135243.147744-1-doucette@bu.edu> <1549031.gagrcBMtR4@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2018 21:19:01 -0000 28/10/2018 21:54, Cody Doucette: > On Sun, Oct 28, 2018 at 6:22 AM Thomas Monjalon wrote: > > 27/07/2018 15:52, Cody Doucette: > > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > > > other IPv6 extension headers when finding the fragment header. > > > > > > According to RFC 8200, there is no guarantee that the IPv6 > > > Fragment extension header will come before any other extension > > > header, even though it is recommended. > > > > > > Signed-off-by: Cody Doucette > > > Signed-off-by: Qiaobin Fu > > > Reviewed-by: Michel Machado > > > --- > > > v3: > > > * Removed compilation flag D_XOPEN_SOURCE=700 from the > > > failsafe driver to allow compilation on freebsd. > > > > How failsafe is related to ip_frag? > > > > > > > v2: > > > * Moved IPv6 extension header definitions to lib_net. > > > > > > drivers/net/failsafe/Makefile | 1 - > > > drivers/net/failsafe/meson.build | 1 - > > > examples/ip_reassembly/main.c | 6 ++-- > > > lib/librte_ip_frag/rte_ip_frag.h | 23 ++++++------- > > > lib/librte_ip_frag/rte_ip_frag_version.map | 1 + > > > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 +++++++++++++++++++++ > > > lib/librte_ip_frag/rte_ipv6_reassembly.c | 4 +-- > > > lib/librte_net/rte_ip.h | 27 +++++++++++++++ > > > lib/librte_port/rte_port_ras.c | 6 ++-- > > > > Changes in failsafe, rte_net and rte_port look like garbage. > > > > Anyway, the ip_frag part requires some review. > > +Cc Konstantin, the maintainer. > > Garbage in what sense? I would be happy to amend with a little more > information. > > The changes to failsafe and rte_net were from previous reviews from > Konstantin: > > https://mails.dpdk.org/archives/dev/2018-June/106023.html > > https://mails.dpdk.org/archives/dev/2018-July/108701.html After a better look, the change in rte_port is fine. But the changes in failsafe and rte_net would be better in their own patch. You can have 3 patches in a patchset (with a cover letter to explain the global idea). Then, failsafe and rte_net changes must be reviewed by their maintainers. Thanks