From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8D7151B315 for ; Wed, 17 Jan 2018 00:23:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3B7C820BF5; Tue, 16 Jan 2018 18:23:15 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 16 Jan 2018 18:23:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=B/dkNK8b40mOdhg2mDlheVAd/S ULWpd8TkK7WEzllA4=; b=EZ3zHX3BVW6df4LJw5Z5AK+IPfo7VQIXaD6WxNzT9A Hkrp/2SfuMgYDN7E0fhnXMfgi2dfm2kq70vkMZZePLdUVH17OoOI8Ne2UOaevyIk lSOLGwdb8ILC8cviaFYFyU/yA5HsolshWiezE8k52dQU2NMJwg1nS0m7T+tqhJyd Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=B/dkNK 8b40mOdhg2mDlheVAd/SULWpd8TkK7WEzllA4=; b=b/CQy6Ewl7dOd0XnXSWTMT PGxP23SwvpULxg4biUKLLZDGfEd1mv/pfqw9m7HEVgvDsdrYE5jrvgjhPlgUyljQ HvWK2DlybjhiUZaE78QivV5t483l3Mf/Rc0Ok5jX+xA+iYmWL2QRl225hOoL2tr1 LmONXEFkm2z4SNrzX3GIj8EFI2J9fGWbA1JQGxsxdfMM9SqXsmGtRpKpCUjMHxoH FShmRDEcj5KGcmk/ka8ZBkyN6O6ADBk/v5yhsgV8S3JaoNlUQxarep4HeKIt8O/4 xhDAAx5o1MdSrm4x0kYZXIp5Hk+gkY53mfZrsH1UqdkoOqHNiEmKha+seX8ruDkg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D56F97E322; Tue, 16 Jan 2018 18:23:14 -0500 (EST) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: Yuanhan Liu , dev@dpdk.org Date: Wed, 17 Jan 2018 00:22:43 +0100 Message-ID: <5324030.qnTS7Rnbq7@xps> In-Reply-To: <20180116231935.pucguvf4u6umvwgu@bidouze.vm.6wind.com> References: <1516114218-21501-1-git-send-email-yliu@fridaylinux.org> <20180116231935.pucguvf4u6umvwgu@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 23:23:15 -0000 17/01/2018 00:19, Ga=EBtan Rivet: > Hi Yuanhan, >=20 > On Tue, Jan 16, 2018 at 10:50:18PM +0800, Yuanhan Liu wrote: > > +The ``devargs`` can be used for whitelisting/blacklisting devices, ide= ntifying > > +DPDK ports and attaching/deatching devices. They all share the same sy= ntax. > > + > > +It is split in 3 categories, where almost everything is optional key/v= alue pairs: > > + > > +* bus (pci, vdev, vmbus, fslmc, etc) > > +* class (eth, crypto, etc) > > +* driver (i40e, mlx5, virtio, etc) > > + > > +The key/value pair describing the category scope is mandatory and must= be the > > +first pair in the category properties. Example: bus=3Dpci, must be pla= ced before > > +id=3D0000:01:00.0. > > + > > +The syntax has below rules: > > + > > +* Between categories, the separator is a slash. > > +* Inside a category, the separator is a comma. > > +* Inside a key/value pair, the separator is an equal sign. > > +* Each category can be used alone. > > + > > +Here is an example with all categories:: > > + > > + bus=3Dpci,id=3D0000:01:00.0/class=3Deth,mac=3D00:11:22:33:44:55/dr= iver=3DPMD_NAME,driverspecificproperty=3DVALUE > > + >=20 > It might be a nitpick, but the driver specific properties might not > follow the key/value pair syntax. At least for the fail-safe, a custom > parsing needs to happen. I think vdev in general will need flexibility. What is more flexible than key/value? > There could be a note that after the comma past the eventual > "driver=3Dxxxx" pair, the syntax is driver-specific and might not follow > the equal-separated key/value pair syntax. Please give an example.