From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f48.google.com (mail-bk0-f48.google.com [209.85.214.48]) by dpdk.org (Postfix) with ESMTP id DE7D93F9 for ; Wed, 26 Mar 2014 17:06:35 +0100 (CET) Received: by mail-bk0-f48.google.com with SMTP id mx12so600882bkb.21 for ; Wed, 26 Mar 2014 09:08:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=+ItGtxJeExGXTkOTD9OtOTi9pa0M+PYOGLA7Xn7tw5A=; b=SY8voNwblz7nwwLyTgsSmRIXE50FKkTcJFTU3L4aVH+JhVP4H28V+R1Bpu3KHbiv8r izyLF7HWmZY+Otd99ClsQLHgkLpc1oCFND1tyqGf0F5FhiWH2zPx7WYQjgwvl50Q+MZR O7bdS5gxtBAr1VIHkuhYiTnGmtGkc1vx7DevpY+HGG4OuWfIp9FkYZrhMmiVRmqcklRa qqGsWcPCfJy5/GXV94AjQPYdZA4Om8zeGSXD5lkYD0ZkTVOokDENtLKLQ8OITjNwZ3g5 asm86vc73+LDbp2qnVGeMO1UtpUAt40XXE5CUHe/LmR2V/dxjeyU9AapYrVkC/xPBy85 eZ3w== X-Gm-Message-State: ALoCoQkU9r7+EqH0hQI2du1I1/J11fKmzYne+fAXW1M4ocD/0jQUfM812zjzEgz/Wq9ZTaxueXyG X-Received: by 10.205.33.81 with SMTP id sn17mr900157bkb.89.1395850088811; Wed, 26 Mar 2014 09:08:08 -0700 (PDT) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id v12sm23953583bko.17.2014.03.26.09.08.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 26 Mar 2014 09:08:07 -0700 (PDT) Message-ID: <5332FB65.3000708@6wind.com> Date: Wed, 26 Mar 2014 17:08:05 +0100 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Thomas Monjalon References: <1395228982-24858-1-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1395228982-24858-1-git-send-email-thomas.monjalon@6wind.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix dependencies when modifying config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Mar 2014 16:06:36 -0000 Hi Thomas, On 03/19/2014 12:36 PM, Thomas Monjalon wrote: > If .config file is changed and .depdirs was built before, > it must be updated. > It is now done silently (-s) in checkconfig rule. > Now .depdirs is not redone if .config is older. > > It has been tested by enabling PMD_PCAP after a default build. > KVARGS dependency should appear in .depdirs. > > Signed-off-by: Thomas Monjalon > --- Looks good to me. Just see one comment below. > # use a "for" in a shell to process dependencies: we don't want this > # task to be run in parallel. > ..PHONY: depdirs It seems there is a typo (..PHONY instead of .PHONY), it could be a good occasion to fix it. In my opinion, it can be done in the same patch as this typo does not create a real issue. Regards, Olivier