From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7450A04DC; Mon, 19 Oct 2020 11:37:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12BC6ACE4; Mon, 19 Oct 2020 11:37:30 +0200 (CEST) Received: from dal3relay53.mxroute.com (dal3relay53.mxroute.com [64.40.27.53]) by dpdk.org (Postfix) with ESMTP id 73DA8ACD1 for ; Mon, 19 Oct 2020 11:37:28 +0200 (CEST) Received: from filter003.mxroute.com ([168.235.111.26] 168-235-111-26.cloud.ramnode.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay53.mxroute.com (ZoneMTA) with ESMTPSA id 175403874590006535.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Mon, 19 Oct 2020 09:37:23 +0000 X-Zone-Loop: 5a9a81f9508f43276a50bde9c93cd6e067b6e98921c1 X-Originating-IP: [168.235.111.26] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter003.mxroute.com (Postfix) with ESMTPS id 0EC4D60024; Mon, 19 Oct 2020 09:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aMZ1Eg3soIiCQ55jIruuFSZAGdSwUxtZ3wwdfyCnar0=; b=ZBgO0a1YKAiEX45dtt+LNaZlmo mNIKAPtsxu0r3NnfDwh72w+FeVEWoLsItmt4f91WItVMIecp0bXijqRyvNEd5xT3MBNyyUX28Gugk hZHlfVlwxdUx2Zj9W/sJ/dUOfh/NxE2KeDTVtQIPaiuejbBml6tsfsElbmS82eA9+e2k4en2DudZa kal+0bMIlYoowhib8HQmzhHp+bLwZS0vVSDR6anLIEWbWePpMsT2UfBrha+DosSVnvp5044LWXZI4 U7S91vlMw4jXJXdUYiDG6T/6g3YN7dYBsNywrwDsaNKNKw6e2Sfew+6EMwRTu5OE+3f5YTr/uyFGZ B0Vnkzaw==; To: Andrew Rybchenko , Andrew Rybchenko , Neil Horman , Thomas Monjalon , Ferruh Yigit Cc: dev@dpdk.org, Ivan Ilchenko References: <1602682146-4722-1-git-send-email-arybchenko@solarflare.com> <1602768646-13142-1-git-send-email-arybchenko@solarflare.com> <1602768646-13142-2-git-send-email-arybchenko@solarflare.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <5335204b-95bc-636d-068a-b9eb403e1d8c@ashroe.eu> Date: Mon, 19 Oct 2020 10:37:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v2 01/11] ethdev: change eth dev stop function to return int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 16/10/2020 18:13, Andrew Rybchenko wrote: > On 10/16/20 2:20 PM, Kinsella, Ray wrote: >> On 15/10/2020 14:30, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Change rte_eth_dev_stop() return value from void to int >>> and return negative errno values in case of error conditions. >>> Also update the usage of the function in ethdev according to >>> the new return type. >>> >>> Signed-off-by: Ivan Ilchenko >>> Signed-off-by: Andrew Rybchenko >>> Acked-by: Thomas Monjalon >>> --- >>> doc/guides/rel_notes/deprecation.rst | 1 - >>> doc/guides/rel_notes/release_20_11.rst | 3 +++ >>> lib/librte_ethdev/rte_ethdev.c | 27 +++++++++++++++++++------- >>> lib/librte_ethdev/rte_ethdev.h | 5 ++++- >>> 4 files changed, 27 insertions(+), 9 deletions(-) >>> >>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >>> index d1f5ed39db..2e04e24374 100644 >>> --- a/doc/guides/rel_notes/deprecation.rst >>> +++ b/doc/guides/rel_notes/deprecation.rst >>> @@ -127,7 +127,6 @@ Deprecation Notices >>> negative errno values to indicate various error conditions (e.g. >>> invalid port ID, unsupported operation, failed operation): >>> >>> - - ``rte_eth_dev_stop`` >>> - ``rte_eth_dev_close`` >>> >>> * ethdev: New offload flags ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. >>> diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst >>> index f8686a50db..c8c30937fa 100644 >>> --- a/doc/guides/rel_notes/release_20_11.rst >>> +++ b/doc/guides/rel_notes/release_20_11.rst >>> @@ -355,6 +355,9 @@ API Changes >>> * vhost: Add a new function ``rte_vhost_crypto_driver_start`` to be called >>> instead of ``rte_vhost_driver_start`` by crypto applications. >>> >>> +* ethdev: changed ``rte_eth_dev_stop`` return value from ``void`` to >>> + ``int`` to provide a way to report various error conditions. >>> + >>> >>> ABI Changes >>> ----------- >>> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c >>> index d9b82df073..b8cf04ef4d 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.c >>> +++ b/lib/librte_ethdev/rte_ethdev.c >>> @@ -1661,7 +1661,7 @@ rte_eth_dev_start(uint16_t port_id) >>> struct rte_eth_dev *dev; >>> struct rte_eth_dev_info dev_info; >>> int diag; >>> - int ret; >>> + int ret, ret_stop; >>> >>> RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); >>> >>> @@ -1695,7 +1695,13 @@ rte_eth_dev_start(uint16_t port_id) >>> RTE_ETHDEV_LOG(ERR, >>> "Error during restoring configuration for device (port %u): %s\n", >>> port_id, rte_strerror(-ret)); >>> - rte_eth_dev_stop(port_id); >>> + ret_stop = rte_eth_dev_stop(port_id); >>> + if (ret_stop != 0) { >>> + RTE_ETHDEV_LOG(ERR, >>> + "Failed to stop device (port %u): %s\n", >>> + port_id, rte_strerror(-ret_stop)); >>> + } >>> + >>> return ret; >>> } >>> >>> @@ -1708,26 +1714,28 @@ rte_eth_dev_start(uint16_t port_id) >>> return 0; >>> } >>> >>> -void >>> +int >>> rte_eth_dev_stop(uint16_t port_id) >>> { >>> struct rte_eth_dev *dev; >>> >>> - RTE_ETH_VALID_PORTID_OR_RET(port_id); >>> + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); >>> dev = &rte_eth_devices[port_id]; >>> >>> - RTE_FUNC_PTR_OR_RET(*dev->dev_ops->dev_stop); >>> + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_stop, -ENOTSUP); >>> >>> if (dev->data->dev_started == 0) { >>> RTE_ETHDEV_LOG(INFO, >>> "Device with port_id=%"PRIu16" already stopped\n", >>> port_id); >>> - return; >>> + return 0; >>> } >>> >>> dev->data->dev_started = 0; >>> (*dev->dev_ops->dev_stop)(dev); >>> rte_ethdev_trace_stop(port_id); >>> + >>> + return 0; >>> } >>> >>> int >>> @@ -1783,7 +1791,12 @@ rte_eth_dev_reset(uint16_t port_id) >>> >>> RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_reset, -ENOTSUP); >>> >>> - rte_eth_dev_stop(port_id); >>> + ret = rte_eth_dev_stop(port_id); >>> + if (ret != 0) { >>> + RTE_ETHDEV_LOG(ERR, >>> + "Failed to stop device (port %u) before reset: %s - ignore\n", >>> + port_id, rte_strerror(-ret)); >> ABI change is 100%, >> Just question the logic of continuing here to do a reset, if you failed to stop the device. > > In the case of reset I'm sure that we should ignore stop failure here. > Typically reset is required to recover from bad state etc and stop > failure in such condition could definitely happen. Ok - thanks for that.