From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EEF55C604 for ; Mon, 4 May 2015 14:44:30 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 04 May 2015 05:44:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,366,1427785200"; d="scan'208";a="704877208" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by fmsmga001.fm.intel.com with ESMTP; 04 May 2015 05:44:07 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.224.2; Mon, 4 May 2015 20:43:51 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.107]) by shsmsx102.ccr.corp.intel.com ([10.239.4.154]) with mapi id 14.03.0224.002; Mon, 4 May 2015 20:43:49 +0800 From: "Qiu, Michael" To: Matthew Hall , Neil Horman Thread-Topic: [dpdk-dev] GitHub sandbox for the DPDK community Thread-Index: AQHQhCdlg1RCyqklQ0KpSAVz9bdNYA== Date: Mon, 4 May 2015 12:43:48 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E602860466B524@SHSMSX101.ccr.corp.intel.com> References: <20150501164512.GB27756@hmsreliant.think-freely.org> <20150501173108.GA24714@mhcomputing.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] GitHub sandbox for the DPDK community X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 12:44:31 -0000 On 5/2/2015 1:33 AM, Matthew Hall wrote:=0A= > On Fri, May 01, 2015 at 12:45:12PM -0400, Neil Horman wrote:=0A= >> Yes, but as you said above, using a web browser doesn't make reviewing p= atches=0A= >> faster. In fact, I would assert that it slows the process down, as it p= revents=0A= >> quick, easy command line access to patch review (as you have with a prop= erly=0A= >> configured MUA). That seems like we're going in the opposite direction = of at=0A= >> least one problem we would like to solve.=0A= > Normally I'm a big command-line supporter. However I have found reviewing= =0A= > patches by email for me is about the most painful workflow.=0A= =0A= What mail client do you use? I think mail client supporting thread mode=0A= is important for patch review.=0A= =0A= Thanks,=0A= Michael=0A= >=0A= > The emails are pages and pages.=0A= >=0A= > The replies from commenters are buried in the walls of text.=0A= >=0A= > Replies to replies keep shifting farther off the edge of the screen. The = code =0A= > gets weirder and weirder to try to read.=0A= >=0A= > Quickly reading over the patchset by scrolling through to get the flavor = of =0A= > it, to see if I'm qualified to review it, and look at the parts I actuall= y =0A= > know about is much harder.=0A= >=0A= > I can go to one place to see every candidate patchset out there, the GH P= ull =0A= > Request page. Then I can just sync up the branch and test it on my own sy= stems =0A= > to see if it works, not just try to read it.=0A= >=0A= > Github automatically minimizes old comments that are already fixed, so th= ey =0A= > don't keep consuming space and mental bandwidth from the review.=0A= >=0A= > All in all, I'd be able to review more DPDK patches faster with the GH = =0A= > interface than having them in the mailing list.=0A= >=0A= > Matthew.=0A= >=0A= =0A=