* Re: [dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD
[not found] <1429003502-20783-1-git-send-email-qiudayu@cn.ibm.com>
@ 2015-04-16 8:09 ` Chen, Jing D
2015-05-12 5:30 ` Qiu, Michael
0 siblings, 1 reply; 6+ messages in thread
From: Chen, Jing D @ 2015-04-16 8:09 UTC (permalink / raw)
To: Michael Qiu, dev
Hi,
> -----Original Message-----
> From: Michael Qiu [mailto:qiudayu@cn.ibm.com]
> Sent: Tuesday, April 14, 2015 5:25 PM
> To: dev@dpdk.org
> Cc: Chen, Jing D; Qiu, Michael
> Subject: [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD
>
> From: Michael Qiu <michael.qiu@intel.com>
>
> In DPDK, max_vfs means vf numbers created, not the max number vfs
> the device supported.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
> lib/librte_pmd_fm10k/fm10k_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_fm10k/fm10k_ethdev.c
> b/lib/librte_pmd_fm10k/fm10k_ethdev.c
> index 0312fad..297ff88 100644
> --- a/lib/librte_pmd_fm10k/fm10k_ethdev.c
> +++ b/lib/librte_pmd_fm10k/fm10k_ethdev.c
> @@ -770,7 +770,7 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
> dev_info->max_tx_queues = hw->mac.max_queues;
> dev_info->max_mac_addrs = 1;
> dev_info->max_hash_mac_addrs = 0;
> - dev_info->max_vfs = FM10K_MAX_VF_NUM;
> + dev_info->max_vfs = dev->pci_dev->max_vfs;
> dev_info->max_vmdq_pools = ETH_64_POOLS;
> dev_info->rx_offload_capa =
> DEV_RX_OFFLOAD_IPV4_CKSUM |
> --
> 1.9.3
Acked-by Jing Chen <jing.d.chen@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD
2015-04-16 8:09 ` [dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD Chen, Jing D
@ 2015-05-12 5:30 ` Qiu, Michael
2015-06-01 13:46 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Qiu, Michael @ 2015-05-12 5:30 UTC (permalink / raw)
To: Chen, Jing D, Michael Qiu, dev, thomas.monjalon
Hi, thomas
What about this patch?
Thanks,
Michael
On 4/16/2015 4:09 PM, Chen, Jing D wrote:
> Hi,
>
>> -----Original Message-----
>> From: Michael Qiu [mailto:qiudayu@cn.ibm.com]
>> Sent: Tuesday, April 14, 2015 5:25 PM
>> To: dev@dpdk.org
>> Cc: Chen, Jing D; Qiu, Michael
>> Subject: [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD
>>
>> From: Michael Qiu <michael.qiu@intel.com>
>>
>> In DPDK, max_vfs means vf numbers created, not the max number vfs
>> the device supported.
>>
>> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
>> ---
>> lib/librte_pmd_fm10k/fm10k_ethdev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_pmd_fm10k/fm10k_ethdev.c
>> b/lib/librte_pmd_fm10k/fm10k_ethdev.c
>> index 0312fad..297ff88 100644
>> --- a/lib/librte_pmd_fm10k/fm10k_ethdev.c
>> +++ b/lib/librte_pmd_fm10k/fm10k_ethdev.c
>> @@ -770,7 +770,7 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
>> dev_info->max_tx_queues = hw->mac.max_queues;
>> dev_info->max_mac_addrs = 1;
>> dev_info->max_hash_mac_addrs = 0;
>> - dev_info->max_vfs = FM10K_MAX_VF_NUM;
>> + dev_info->max_vfs = dev->pci_dev->max_vfs;
>> dev_info->max_vmdq_pools = ETH_64_POOLS;
>> dev_info->rx_offload_capa =
>> DEV_RX_OFFLOAD_IPV4_CKSUM |
>> --
>> 1.9.3
> Acked-by Jing Chen <jing.d.chen@intel.com>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD
2015-05-12 5:30 ` Qiu, Michael
@ 2015-06-01 13:46 ` Thomas Monjalon
2015-06-02 2:23 ` Qiu, Michael
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2015-06-01 13:46 UTC (permalink / raw)
To: Qiu, Michael; +Cc: dev, Michael Qiu
2015-05-12 05:30, Qiu, Michael:
> Hi, thomas
>
> What about this patch?
It seems this patch was not *really* sent to dev@dpdk.org.
Please re-send, keeping the Acked-by line.
> On 4/16/2015 4:09 PM, Chen, Jing D wrote:
> > From: Michael Qiu [mailto:qiudayu@cn.ibm.com]
> >> From: Michael Qiu <michael.qiu@intel.com>
> >>
> >> In DPDK, max_vfs means vf numbers created, not the max number vfs
> >> the device supported.
> >>
> >> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> >> ---
> >> lib/librte_pmd_fm10k/fm10k_ethdev.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/lib/librte_pmd_fm10k/fm10k_ethdev.c
> >> b/lib/librte_pmd_fm10k/fm10k_ethdev.c
> >> index 0312fad..297ff88 100644
> >> --- a/lib/librte_pmd_fm10k/fm10k_ethdev.c
> >> +++ b/lib/librte_pmd_fm10k/fm10k_ethdev.c
> >> @@ -770,7 +770,7 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
> >> dev_info->max_tx_queues = hw->mac.max_queues;
> >> dev_info->max_mac_addrs = 1;
> >> dev_info->max_hash_mac_addrs = 0;
> >> - dev_info->max_vfs = FM10K_MAX_VF_NUM;
> >> + dev_info->max_vfs = dev->pci_dev->max_vfs;
> >> dev_info->max_vmdq_pools = ETH_64_POOLS;
> >> dev_info->rx_offload_capa =
> >> DEV_RX_OFFLOAD_IPV4_CKSUM |
> >> --
> >> 1.9.3
> > Acked-by Jing Chen <jing.d.chen@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD
2015-06-01 13:46 ` Thomas Monjalon
@ 2015-06-02 2:23 ` Qiu, Michael
0 siblings, 0 replies; 6+ messages in thread
From: Qiu, Michael @ 2015-06-02 2:23 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Michael Qiu
On 6/1/2015 9:47 PM, Thomas Monjalon wrote:
> 2015-05-12 05:30, Qiu, Michael:
>> Hi, thomas
>>
>> What about this patch?
> It seems this patch was not *really* sent to dev@dpdk.org.
> Please re-send, keeping the Acked-by line.
OK, I will resend it.
Thanks,
Michael
>> On 4/16/2015 4:09 PM, Chen, Jing D wrote:
>>> From: Michael Qiu [mailto:qiudayu@cn.ibm.com]
>>>> From: Michael Qiu <michael.qiu@intel.com>
>>>>
>>>> In DPDK, max_vfs means vf numbers created, not the max number vfs
>>>> the device supported.
>>>>
>>>> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
>>>> ---
>>>> lib/librte_pmd_fm10k/fm10k_ethdev.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/lib/librte_pmd_fm10k/fm10k_ethdev.c
>>>> b/lib/librte_pmd_fm10k/fm10k_ethdev.c
>>>> index 0312fad..297ff88 100644
>>>> --- a/lib/librte_pmd_fm10k/fm10k_ethdev.c
>>>> +++ b/lib/librte_pmd_fm10k/fm10k_ethdev.c
>>>> @@ -770,7 +770,7 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
>>>> dev_info->max_tx_queues = hw->mac.max_queues;
>>>> dev_info->max_mac_addrs = 1;
>>>> dev_info->max_hash_mac_addrs = 0;
>>>> - dev_info->max_vfs = FM10K_MAX_VF_NUM;
>>>> + dev_info->max_vfs = dev->pci_dev->max_vfs;
>>>> dev_info->max_vmdq_pools = ETH_64_POOLS;
>>>> dev_info->rx_offload_capa =
>>>> DEV_RX_OFFLOAD_IPV4_CKSUM |
>>>> --
>>>> 1.9.3
>>> Acked-by Jing Chen <jing.d.chen@intel.com>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD
2015-06-02 2:28 Michael Qiu
@ 2015-06-02 16:06 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2015-06-02 16:06 UTC (permalink / raw)
To: Michael Qiu; +Cc: dev
2015-06-02 10:28, Michael Qiu:
> In DPDK, max_vfs means vf numbers created, not the max number vfs
> the device supported.
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> Acked-by Jing Chen <jing.d.chen@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD
@ 2015-06-02 2:28 Michael Qiu
2015-06-02 16:06 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Michael Qiu @ 2015-06-02 2:28 UTC (permalink / raw)
To: dev
In DPDK, max_vfs means vf numbers created, not the max number vfs
the device supported.
Signed-off-by: Michael Qiu <michael.qiu@intel.com>
Acked-by Jing Chen <jing.d.chen@intel.com>
---
lib/librte_pmd_fm10k/fm10k_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_fm10k/fm10k_ethdev.c b/lib/librte_pmd_fm10k/fm10k_ethdev.c
index 0312fad..297ff88 100644
--- a/lib/librte_pmd_fm10k/fm10k_ethdev.c
+++ b/lib/librte_pmd_fm10k/fm10k_ethdev.c
@@ -770,7 +770,7 @@ fm10k_dev_infos_get(struct rte_eth_dev *dev,
dev_info->max_tx_queues = hw->mac.max_queues;
dev_info->max_mac_addrs = 1;
dev_info->max_hash_mac_addrs = 0;
- dev_info->max_vfs = FM10K_MAX_VF_NUM;
+ dev_info->max_vfs = dev->pci_dev->max_vfs;
dev_info->max_vmdq_pools = ETH_64_POOLS;
dev_info->rx_offload_capa =
DEV_RX_OFFLOAD_IPV4_CKSUM |
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-06-02 16:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1429003502-20783-1-git-send-email-qiudayu@cn.ibm.com>
2015-04-16 8:09 ` [dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD Chen, Jing D
2015-05-12 5:30 ` Qiu, Michael
2015-06-01 13:46 ` Thomas Monjalon
2015-06-02 2:23 ` Qiu, Michael
2015-06-02 2:28 Michael Qiu
2015-06-02 16:06 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).