From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix wrong message in testpmd
Date: Tue, 28 Jul 2015 18:44:20 +0000 [thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286046F6B3C@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20150708090441.GA152@bricha3-MOBL3>
On 2015/7/8 2:04, Richardson, Bruce wrote:
> On Wed, Jul 08, 2015 at 07:16:21AM +0000, Qiu, Michael wrote:
[.../...]
>>> port = &ports[pi];
>>> if (rte_atomic16_cmpset(&(port->port_status),
>>> + RTE_PORT_CLOSED, RTE_PORT_CLOSED) == 1) {
>>> + printf("Port %d is already closed\n", pi);
>>> + continue;
>>> + }
>>> +
>>> + if (rte_atomic16_cmpset(&(port->port_status),
>>> RTE_PORT_STOPPED, RTE_PORT_HANDLING) == 0) {
>>> printf("Port %d is now not stopped\n", pi);
>>> continue;
> I know it's not part of your change, but "Now not stopped" doesn't really seem
> right to me. What is the message actually trying to report?
It is just make sure the port is in stopped state. So it will check if
it is not in RTE_PORT_STOPPED stat or fail to set to RTE_PORT_HANDLING,
it will report as "now not stopped"
Thanks,
Michael
>
> /Bruce
next prev parent reply other threads:[~2015-07-28 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 7:56 Michael Qiu
2015-07-08 7:16 ` Qiu, Michael
2015-07-08 9:04 ` Bruce Richardson
2015-07-28 18:44 ` Qiu, Michael [this message]
2015-07-29 22:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533710CFB86FA344BFBF2D6802E60286046F6B3C@SHSMSX101.ccr.corp.intel.com \
--to=michael.qiu@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).