From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E17E7C4FC for ; Tue, 28 Jul 2015 20:44:24 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 28 Jul 2015 11:44:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,565,1432623600"; d="scan'208";a="771633247" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga002.fm.intel.com with ESMTP; 28 Jul 2015 11:44:23 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 29 Jul 2015 02:44:22 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.18]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.38]) with mapi id 14.03.0224.002; Wed, 29 Jul 2015 02:44:20 +0800 From: "Qiu, Michael" To: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] testpmd: Fix wrong message in testpmd Thread-Index: AQHQrlNRU65GkoaZSE2tKeJ/KHBJsw== Date: Tue, 28 Jul 2015 18:44:20 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286046F6B3C@SHSMSX101.ccr.corp.intel.com> References: <1435132585-10192-1-git-send-email-michael.qiu@intel.com> <533710CFB86FA344BFBF2D6802E60286046B2833@SHSMSX101.ccr.corp.intel.com> <20150708090441.GA152@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix wrong message in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2015 18:44:25 -0000 On 2015/7/8 2:04, Richardson, Bruce wrote:=0A= > On Wed, Jul 08, 2015 at 07:16:21AM +0000, Qiu, Michael wrote:=0A= =0A= [.../...]=0A= =0A= >>> port =3D &ports[pi];=0A= >>> if (rte_atomic16_cmpset(&(port->port_status),=0A= >>> + RTE_PORT_CLOSED, RTE_PORT_CLOSED) =3D=3D 1) {=0A= >>> + printf("Port %d is already closed\n", pi);=0A= >>> + continue;=0A= >>> + }=0A= >>> +=0A= >>> + if (rte_atomic16_cmpset(&(port->port_status),=0A= >>> RTE_PORT_STOPPED, RTE_PORT_HANDLING) =3D=3D 0) {=0A= >>> printf("Port %d is now not stopped\n", pi);=0A= >>> continue;=0A= > I know it's not part of your change, but "Now not stopped" doesn't really= seem=0A= > right to me. What is the message actually trying to report?=0A= =0A= It is just make sure the port is in stopped state. So it will check if=0A= it is not in RTE_PORT_STOPPED stat or fail to set to RTE_PORT_HANDLING,=0A= it will report as "now not stopped"=0A= =0A= =0A= Thanks,=0A= Michael=0A= >=0A= > /Bruce=0A= =0A=