From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3CC0D5697 for ; Fri, 7 Aug 2015 20:52:39 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 07 Aug 2015 11:52:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,630,1432623600"; d="scan'208";a="537905421" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by FMSMGA003.fm.intel.com with ESMTP; 07 Aug 2015 11:52:37 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.224.2; Sat, 8 Aug 2015 02:52:36 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.18]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.188]) with mapi id 14.03.0224.002; Sat, 8 Aug 2015 02:52:35 +0800 From: "Qiu, Michael" To: "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding Thread-Index: AQHQ0MFHSfXj+Pb4lkOSv1X8Ti16cA== Date: Fri, 7 Aug 2015 18:52:34 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E6028604703736@SHSMSX101.ccr.corp.intel.com> References: <1438918156-1259-1-git-send-email-michael.qiu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2015 18:52:39 -0000 On 2015/8/7 9:06, Zhang, Helin wrote:=0A= >=0A= >> -----Original Message-----=0A= >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu=0A= >> Sent: Thursday, August 6, 2015 8:29 PM=0A= >> To: dev@dpdk.org=0A= >> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding= =0A= >>=0A= >> For some ethnet-switch like intel RRC, all the packet forwarded out by D= PDK will=0A= >> be dropped in switch side, so the packet generator will never receive th= e packet.=0A= > Is it because of anti-sproof? E.g. When the hardware found that the dest = mac is the=0A= > port itself, then it will be dropped during TX.=0A= > You need to tell the root cause, and why we need to modify like this.=0A= =0A= Actually, it is not the hardware from PEP(PCI End Point) side, but the=0A= switch side.=0A= =0A= The TX is OK for DPDK and NIC, but in switch, it receives the packet and=0A= try to forward it, but the dest mac is the same as the NIC which=0A= transmit this packet.=0A= So switch will drop it as "Loopback Suppression Drop" in RRC. This=0A= should only happen when switch forwarding packets using dest mac.=0A= =0A= =0A= >=0A= >> Signed-off-by: Michael Qiu =0A= >> ---=0A= >> app/test-pmd/csumonly.c | 4 ++++=0A= >> 1 file changed, 4 insertions(+)=0A= >>=0A= >> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index=0A= >> 1bf3485..bf8af1d 100644=0A= >> --- a/app/test-pmd/csumonly.c=0A= >> +++ b/app/test-pmd/csumonly.c=0A= >> @@ -550,6 +550,10 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)= =0A= >> * and inner headers */=0A= >>=0A= >> eth_hdr =3D rte_pktmbuf_mtod(m, struct ether_hdr *);=0A= >> + ether_addr_copy(&peer_eth_addrs[fs->peer_addr],=0A= >> + ð_hdr->d_addr);=0A= >> + ether_addr_copy(&ports[fs->tx_port].eth_addr,=0A= >> + ð_hdr->s_addr);=0A= > Is it really necessary? Why other NICs do not need this?=0A= =0A= Because other NICs is connect directly to packet generator...., if we=0A= using switch to connect the generator and the NICs, I think it will need=0A= this.=0A= =0A= Thanks,=0A= Michael=0A= >=0A= >> parse_ethernet(eth_hdr, &info);=0A= >> l3_hdr =3D (char *)eth_hdr + info.l2_len;=0A= >>=0A= >> --=0A= >> 1.9.3=0A= >=0A= =0A=