DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding
Date: Mon, 10 Aug 2015 04:45:58 +0000	[thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E6028604711308@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <F52918179C57134FAEC9EA62FA2F962511C6E983@shsmsx102.ccr.corp.intel.com>

On 2015/8/7 17:13, Ouyang, Changchun wrote:
>
>>

[.../...]

>>
>>  		eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *);
>> +		ether_addr_copy(&peer_eth_addrs[fs->peer_addr],
>> +				&eth_hdr->d_addr);
>> +		ether_addr_copy(&ports[fs->tx_port].eth_addr,
>> +				&eth_hdr->s_addr);
>> Is it really necessary? Why other NICs do not need this?
>>
> Seems the behavior changes from io fwd into mac fwd?

Yes, but I think it is no influence for checksum offload.

Thanks,
Michael
>>>  		parse_ethernet(eth_hdr, &info);
>>>  		l3_hdr = (char *)eth_hdr + info.l2_len;
>>>
>>> --
>>> 1.9.3
>


  reply	other threads:[~2015-08-10  4:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07  3:29 Michael Qiu
2015-08-07 16:05 ` De Lara Guarch, Pablo
2015-08-07 18:42   ` Qiu, Michael
2015-08-07 16:06 ` Zhang, Helin
2015-08-07 18:52   ` Qiu, Michael
2015-08-07 20:37     ` Zhang, Helin
2015-08-07 21:16       ` Qiu, Michael
2015-08-08  0:13   ` Ouyang, Changchun
2015-08-10  4:45     ` Qiu, Michael [this message]
2015-08-26  6:12 ` Liu, Jijiang
2015-09-14  3:37   ` Qiu, Michael
2015-10-13  6:29   ` Qiu, Michael
2015-10-24 16:52     ` Thomas Monjalon
2015-10-26 19:47       ` De Lara Guarch, Pablo
2015-10-29 22:55         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533710CFB86FA344BFBF2D6802E6028604711308@SHSMSX101.ccr.corp.intel.com \
    --to=michael.qiu@intel.com \
    --cc=changchun.ouyang@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).