From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.qiu@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 153952A07
 for <dev@dpdk.org>; Mon, 10 Aug 2015 06:46:11 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 09 Aug 2015 21:46:11 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,641,1432623600"; d="scan'208";a="745421558"
Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86])
 by orsmga001.jf.intel.com with ESMTP; 09 Aug 2015 21:46:10 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Mon, 10 Aug 2015 12:46:00 +0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.18]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.126]) with mapi id 14.03.0224.002;
 Mon, 10 Aug 2015 12:45:59 +0800
From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>, "Zhang, Helin"
 <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding
Thread-Index: AQHQ0MFHSfXj+Pb4lkOSv1X8Ti16cA==
Date: Mon, 10 Aug 2015 04:45:58 +0000
Message-ID: <533710CFB86FA344BFBF2D6802E6028604711308@SHSMSX101.ccr.corp.intel.com>
References: <1438918156-1259-1-git-send-email-michael.qiu@intel.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8BCD4A@SHSMSX104.ccr.corp.intel.com>
 <F52918179C57134FAEC9EA62FA2F962511C6E983@shsmsx102.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2015 04:46:12 -0000

On 2015/8/7 17:13, Ouyang, Changchun wrote:=0A=
>=0A=
>>=0A=
=0A=
[.../...]=0A=
=0A=
>>=0A=
>>  		eth_hdr =3D rte_pktmbuf_mtod(m, struct ether_hdr *);=0A=
>> +		ether_addr_copy(&peer_eth_addrs[fs->peer_addr],=0A=
>> +				&eth_hdr->d_addr);=0A=
>> +		ether_addr_copy(&ports[fs->tx_port].eth_addr,=0A=
>> +				&eth_hdr->s_addr);=0A=
>> Is it really necessary? Why other NICs do not need this?=0A=
>>=0A=
> Seems the behavior changes from io fwd into mac fwd?=0A=
=0A=
Yes, but I think it is no influence for checksum offload.=0A=
=0A=
Thanks,=0A=
Michael=0A=
>>>  		parse_ethernet(eth_hdr, &info);=0A=
>>>  		l3_hdr =3D (char *)eth_hdr + info.l2_len;=0A=
>>>=0A=
>>> --=0A=
>>> 1.9.3=0A=
>=0A=
=0A=