Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding

["Qiu, Michael" <michael.qiu@intel.com>]

Hi, all

any other comments about this patch?

Thanks,
Michael

On 8/26/2015 2:12 PM, Liu, Jijiang wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu
>> Sent: Friday, August 07, 2015 11:29 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding
>>
>> For some ethnet-switch like intel RRC, all the packet forwarded out by DPDK
>> will be dropped in switch side, so the packet generator will never receive the
>> packet.
>>
>> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
>> ---
>>  app/test-pmd/csumonly.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index
>> 1bf3485..bf8af1d 100644
>> --- a/app/test-pmd/csumonly.c
>> +++ b/app/test-pmd/csumonly.c
>> @@ -550,6 +550,10 @@ pkt_burst_checksum_forward(struct fwd_stream
>> *fs)
>>  		 * and inner headers */
>>
>>  		eth_hdr = rte_pktmbuf_mtod(m, struct ether_hdr *);
>> +		ether_addr_copy(&peer_eth_addrs[fs->peer_addr],
>> +				&eth_hdr->d_addr);
>> +		ether_addr_copy(&ports[fs->tx_port].eth_addr,
>> +				&eth_hdr->s_addr);
>>  		parse_ethernet(eth_hdr, &info);
>>  		l3_hdr = (char *)eth_hdr + info.l2_len;
>>
>> --
>> 1.9.3
> The change will affect on the csum fwd performance.
> But I also think the change is necessary, or we cannot use csumonly fwd mode in guest。
>
> Acked-by: Jijiang Liu <Jijiang.liu@intel.com>
>
>