From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2086F8DA6 for ; Wed, 23 Sep 2015 08:56:57 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 22 Sep 2015 23:56:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,577,1437462000"; d="scan'208";a="795369687" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 22 Sep 2015 23:56:56 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 22 Sep 2015 23:56:56 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 22 Sep 2015 23:56:56 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.75]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.210]) with mapi id 14.03.0248.002; Wed, 23 Sep 2015 14:56:54 +0800 From: "Qiu, Michael" To: Stephen Hemminger , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v2] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data Thread-Index: AQHQ9L6IT0k4kpPGQUefpiYRS2BLYw== Date: Wed, 23 Sep 2015 06:56:53 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E602861989289E@SHSMSX101.ccr.corp.intel.com> References: <1442440284-6175-1-git-send-email-pablo.de.lara.guarch@intel.com> <20150921154024.3890eb76@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 06:56:58 -0000 On 2015/9/22 6:40, Stephen Hemminger wrote:=0A= > On Wed, 16 Sep 2015 22:51:24 +0100=0A= > Pablo de Lara wrote:=0A= >=0A= >> This is important to avoid trying to start/stop twice a queue,=0A= >> which will result in undefined behaviour=0A= >> (which may cause RX/TX disruption).=0A= >>=0A= >> Mind that only the PMDs which have queue_start/stop functions=0A= >> have been changed to update this field, as the functions will=0A= >> check the queue state before switching it.=0A= >>=0A= >> Signed-off-by: Pablo de Lara =0A= > I agree that the DPDK API should check for buggy manipulation=0A= > in the control path. But this should be done in generic code.=0A= > Anything where you have to change any driver is making more work=0A= > than necessary.=0A= =0A= I agree with you, but I have a question, why we need expose the queue=0A= start and stop function to app?=0A= =0A= In my opinion, user app will hardly to start a device but stop the=0A= device queue. what's the purpose of it?=0A= =0A= Thanks,=0A= Michael=0A= =0A=