From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id C1BD38E80 for ; Tue, 13 Oct 2015 08:30:14 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 12 Oct 2015 23:29:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,676,1437462000"; d="scan'208";a="579550989" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 12 Oct 2015 23:29:21 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 12 Oct 2015 23:29:21 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 12 Oct 2015 23:29:20 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.106]) with mapi id 14.03.0248.002; Tue, 13 Oct 2015 14:29:19 +0800 From: "Qiu, Michael" To: "dev@dpdk.org" , "thomas.monjalon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding Thread-Index: AQHQ0MFHSfXj+Pb4lkOSv1X8Ti16cA== Date: Tue, 13 Oct 2015 06:29:18 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E6028621B48000@SHSMSX101.ccr.corp.intel.com> References: <1438918156-1259-1-git-send-email-michael.qiu@intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC057D2B87@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2015 06:30:15 -0000 Hi, Thomas=0A= =0A= Any comments on this patch? Is it suitable for DPDK?=0A= =0A= Thanks,=0A= Michael=0A= On 2015/8/26 14:12, Liu, Jijiang wrote:=0A= >=0A= >> -----Original Message-----=0A= >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Qiu=0A= >> Sent: Friday, August 07, 2015 11:29 AM=0A= >> To: dev@dpdk.org=0A= >> Subject: [dpdk-dev] [PATCH] testpmd: modify the mac of csum forwarding= =0A= >>=0A= >> For some ethnet-switch like intel RRC, all the packet forwarded out by D= PDK=0A= >> will be dropped in switch side, so the packet generator will never recei= ve the=0A= >> packet.=0A= >>=0A= >> Signed-off-by: Michael Qiu =0A= >> ---=0A= >> app/test-pmd/csumonly.c | 4 ++++=0A= >> 1 file changed, 4 insertions(+)=0A= >>=0A= >> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index=0A= >> 1bf3485..bf8af1d 100644=0A= >> --- a/app/test-pmd/csumonly.c=0A= >> +++ b/app/test-pmd/csumonly.c=0A= >> @@ -550,6 +550,10 @@ pkt_burst_checksum_forward(struct fwd_stream=0A= >> *fs)=0A= >> * and inner headers */=0A= >>=0A= >> eth_hdr =3D rte_pktmbuf_mtod(m, struct ether_hdr *);=0A= >> + ether_addr_copy(&peer_eth_addrs[fs->peer_addr],=0A= >> + ð_hdr->d_addr);=0A= >> + ether_addr_copy(&ports[fs->tx_port].eth_addr,=0A= >> + ð_hdr->s_addr);=0A= >> parse_ethernet(eth_hdr, &info);=0A= >> l3_hdr =3D (char *)eth_hdr + info.l2_len;=0A= >>=0A= >> --=0A= >> 1.9.3=0A= > The change will affect on the csum fwd performance.=0A= > But I also think the change is necessary, or we cannot use csumonly fwd m= ode in guest=1B$B!#=1B(B=0A= >=0A= > Acked-by: Jijiang Liu =0A= >=0A= >=0A= =0A=