DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Qiu, Michael" <michael.qiu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] Fix compile issue in i686 platform
Date: Fri, 27 Nov 2015 02:02:24 +0000	[thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E6028621B8CC43@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <2567901.2WFrbjZVWM@xps13>

On 2015/11/27 5:15, Thomas Monjalon wrote:
> 2015-11-26 09:35, Michael Qiu:
>> In i686 platform, long is 32bit, so XXX_CYCLECOUNTER_MASK
>> need define as 'ULL'
>>
>> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> This patch is correct but the description is not exact:
> I have no issue with my i686 compiler.
> For future reference, please could you be more precise
> about the reproduction environment? Is it related to a specific compiler?

OK, I will be for careful about the compile and os next time.

> We also need to add these lines:
> Fixes: 9c857bf6be87 ("igb: support ieee1588 functions for device time")
> Fixes: 1c4445e1f28e ("ixgbe: support ieee1588 functions for device time")
> Fixes: f3a4e40eca0c ("i40e: support ieee1588 functions for device time")

So I will repost the patch set.

Thanks,
Michael


  reply	other threads:[~2015-11-27  2:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26  1:35 [dpdk-dev] [PATCH 1/2] examples/distributor: Fix compile issue Michael Qiu
2015-11-26  1:35 ` [dpdk-dev] [PATCH 2/2] Fix compile issue in i686 platform Michael Qiu
2015-11-26 21:14   ` Thomas Monjalon
2015-11-27  2:02     ` Qiu, Michael [this message]
2015-11-26 14:29 ` [dpdk-dev] [PATCH 1/2] examples/distributor: Fix compile issue Thomas Monjalon
2015-11-26 21:01 ` Thomas Monjalon
2015-11-27  1:16 ` Wan, Qun
2015-11-27  3:36 ` [dpdk-dev] [PATCH 1/2 v2] " Michael Qiu
2015-11-27  3:36   ` [dpdk-dev] [PATCH 2/2 v2] Fix compile issue in i686 platform Michael Qiu
2015-11-27  9:10     ` Thomas Monjalon
2015-11-27 12:21   ` [dpdk-dev] [PATCH 1/2 v2] examples/distributor: Fix compile issue De Lara Guarch, Pablo
2015-11-27 20:49     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533710CFB86FA344BFBF2D6802E6028621B8CC43@SHSMSX101.ccr.corp.intel.com \
    --to=michael.qiu@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).