From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <michael.qiu@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 443A42EDA for <dev@dpdk.org>; Mon, 1 Feb 2016 09:31:51 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 01 Feb 2016 00:31:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,379,1449561600"; d="scan'208";a="893615882" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 01 Feb 2016 00:31:50 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Feb 2016 00:31:49 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 1 Feb 2016 00:31:49 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.215]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.218]) with mapi id 14.03.0248.002; Mon, 1 Feb 2016 16:31:44 +0800 From: "Qiu, Michael" <michael.qiu@intel.com> To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> Thread-Topic: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on Intel X550 NIC Thread-Index: AQHRWmNiys3sP2cjn0KklWMFyM2L+g== Date: Mon, 1 Feb 2016 08:31:44 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E6028622F281DE@SHSMSX101.ccr.corp.intel.com> References: <1454051035-25757-1-git-send-email-wenzhuo.lu@intel.com> <533710CFB86FA344BFBF2D6802E6028622F260A3@SHSMSX101.ccr.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090342601B@shsmsx102.ccr.corp.intel.com> <20160201013948.GZ4257@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwarding on Intel X550 NIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 01 Feb 2016 08:31:51 -0000 On 2/1/2016 9:38 AM, Yuanhan Liu wrote:=0A= > On Mon, Feb 01, 2016 at 01:04:52AM +0000, Lu, Wenzhuo wrote:=0A= >> Hi,=0A= >>=0A= >>> -----Original Message-----=0A= >>> From: Qiu, Michael=0A= >>> Sent: Friday, January 29, 2016 3:16 PM=0A= >>> To: Lu, Wenzhuo; dev@dpdk.org=0A= >>> Subject: Re: [dpdk-dev] [PATCH 0/8] support E-tag offloading and forwar= ding on=0A= >>> Intel X550 NIC=0A= >>>=0A= >>> Hi, Wenzhuo=0A= >>>=0A= >>> Better to explain what E-tag is, so that reviewers could known it.=0A= >> Yes, it's better. But not sure where should I add this info. In release = note or just cover letter? Any suggestion? Thanks.=0A= > It should be done in the first patch introduced E-tag, so that it will=0A= > be in the git log history. And of course, it does no harm at all to=0A= > mention (briefly) it again in cover letter, so that reviewer/maintainer= =0A= > has a brief understanding of your whole patchset first.=0A= >=0A= > --yliu=0A= =0A= Yes, in my view, cover letter is a good place, but as want to be in git=0A= log history, it would be better to include in the right patch of the=0A= feature, because most of time, the first patch is not core related to=0A= new feature, perhaps only some prepare code.=0A= =0A= My opinion is to explain it where it first be mentioned in the code.=0A= =0A= But again, it OK for Yuanhan's solution, the only thing you want to do=0A= is think you are a reviewer, and want to review you patch, what do you want= .=0A= =0A= Thanks,=0A= Michael=0A= =0A=