From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1BD4429D2 for ; Thu, 25 Feb 2016 08:56:01 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 24 Feb 2016 23:56:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,497,1449561600"; d="scan'208";a="910874227" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 24 Feb 2016 23:56:01 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 24 Feb 2016 23:56:00 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 24 Feb 2016 23:56:00 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.132]) with mapi id 14.03.0248.002; Thu, 25 Feb 2016 15:55:50 +0800 From: "Qiu, Michael" To: Yuanhan Liu Thread-Topic: [dpdk-dev] [PATCH] vhost: broadcast RARP pkt by injecting it to receiving mbuf array Thread-Index: AQHRbt1ERIiS12s4JkmDPjs6mQfXNQ== Date: Thu, 25 Feb 2016 07:55:49 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E6028622F55A37@SHSMSX101.ccr.corp.intel.com> References: <20160219070326.GR21426@yliu-dev.sh.intel.com> <1456151771-15382-1-git-send-email-yuanhan.liu@linux.intel.com> <533710CFB86FA344BFBF2D6802E6028622F54AB4@SHSMSX101.ccr.corp.intel.com> <20160224082855.GE14300@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , Victor Kaplansky , "Michael S. Tsirkin" Subject: Re: [dpdk-dev] [PATCH] vhost: broadcast RARP pkt by injecting it to receiving mbuf array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Feb 2016 07:56:02 -0000 On 2/24/2016 4:27 PM, Yuanhan Liu wrote:=0A= > On Wed, Feb 24, 2016 at 08:15:36AM +0000, Qiu, Michael wrote:=0A= >> On 2/22/2016 10:35 PM, Yuanhan Liu wrote:=0A= >>> Broadcast RARP packet by injecting it to receiving mbuf array at=0A= >>> rte_vhost_dequeue_burst().=0A= >>>=0A= >>> Commit 33226236a35e ("vhost: handle request to send RARP") iterates=0A= >>> all host interfaces and then broadcast it by all of them. It did=0A= >>> notify the switches about the new location of the migrated VM, however,= =0A= >>> the mac learning table in the target host is wrong (at least in my=0A= >>> test with OVS):=0A= >>>=0A= >>> $ ovs-appctl fdb/show ovsbr0=0A= >>> port VLAN MAC Age=0A= >>> 1 0 b6:3c:72:71:cd:4d 10=0A= >>> LOCAL 0 b6:3c:72:71:cd:4e 10=0A= >>> LOCAL 0 52:54:00:12:34:68 9=0A= >>> 1 0 56:f6:64:2c:bc:c0 1=0A= >>>=0A= >>> Where 52:54:00:12:34:68 is the mac of the VM. As you can see from the= =0A= >>> above, the port learned is "LOCAL", which is the "ovsbr0" port. That=0A= >>> is reasonable, since we indeed send the pkt by the "ovsbr0" interface.= =0A= >>>=0A= >>> The wrong mac table lead all the packets to the VM go to the "ovsbr0"= =0A= >>> in the end, which ends up with all packets being lost, until the guest= =0A= >>> send a ARP quest (or reply) to refresh the mac learning table.=0A= >>>=0A= >>> Jianfeng then came up with a solution I have thought of firstly but NAK= ed=0A= >> Is it suitable to mention someone in the commit log?=0A= > Why it's not? It's not a secret name or something like that after all :)= =0A= >=0A= > On the other hand, it's way of thanking Jianfeng's contribution to this= =0A= > patch.=0A= =0A= OK, I've never seen this fashion before, forgive me.=0A= =0A= Thanks,=0A= Michael=0A= >=0A= > --yliu=0A= >=0A= =0A=