From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0A2752B9C for ; Thu, 3 Mar 2016 06:53:56 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 02 Mar 2016 21:53:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,531,1449561600"; d="scan'208";a="662953222" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 02 Mar 2016 21:53:55 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Mar 2016 21:53:55 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Mar 2016 21:53:55 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.136]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.18]) with mapi id 14.03.0248.002; Thu, 3 Mar 2016 13:53:53 +0800 From: "Qiu, Michael" To: Stephen Hurd , Thomas Monjalon Thread-Topic: [dpdk-dev] New driver (large patch) question. Thread-Index: AQHRdDelxF/IvC23DEaU403aAAaunQ== Date: Thu, 3 Mar 2016 05:53:52 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E6028622F5BCE5@SHSMSX101.ccr.corp.intel.com> References: <1915798.D06pWLxedU@xps13> <3156888.xIWalfADA6@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" , Carl Tung , David Christensen Subject: Re: [dpdk-dev] New driver (large patch) question. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 05:53:59 -0000 On 3/3/2016 7:11 AM, Stephen Hurd wrote:=0A= > On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon =0A= > wrote:=0A= >=0A= >>> The comments in it are the only publicly available=0A= >>> documentation on the hardware I'm aware of.=0A= >> So you must keep the comments.=0A= >>=0A= > That's my goal, but the comments are well over the 300k limit.=0A= >=0A= >=0A= >>> The driver itself doesn't have a lot of optional features in it, it's t= he=0A= >>> header file that's too big.=0A= >> It is big because there are many different things.=0A= >> You can split the file in different patches.=0A= >> Examples:=0A= >> - a patch for RSS will bring the hardware structures for RSS=0A= >> - a patch for the stats will bring the hardware stats structures= =0A= >> etc=0A= >>=0A= > Should I split additional definitions/documentation that's not currently= =0A= > used in the driver as well? Or should it stay as only enough to document= =0A= > what the driver already does?=0A= >=0A= > The header file is expected to be publicly released in the future, so I= =0A= > tried to keep it as close to the original as possible. I'm not strongly= =0A= > attached to this approach, but it does make it easier to support future= =0A= > firmware releases.=0A= >=0A= > It's a fairly work-intensive project to deconstruct the existing driver= =0A= > into a series of small patches that work at each step, is this a hard=0A= > requirement? (if so, I'd better get cracking)=0A= =0A= Does original header file has it's own commit log(like it in other=0A= project)? If yes, it could make your life simpler.=0A= =0A= Thanks,=0A= Michael =0A= > PS: please answer inline=0A= > Sorry, $work just switched us to GMail and I'm still learning the ropes.= =0A= >=0A= =0A=