From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1408F7F0C for ; Fri, 21 Nov 2014 03:12:34 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 20 Nov 2014 18:20:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,427,1413270000"; d="scan'208";a="640885359" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by orsmga002.jf.intel.com with ESMTP; 20 Nov 2014 18:23:05 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 21 Nov 2014 10:23:03 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.86]) with mapi id 14.03.0195.001; Fri, 21 Nov 2014 10:23:02 +0800 From: "Qiu, Michael" To: "Zang, Zhida" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] i40e: fixed tx stats bug Thread-Index: AQHQA9TzoaEoq5QfdkyyKQxnL+fDFpxoMRaAgAIrB1A= Date: Fri, 21 Nov 2014 02:23:02 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286C99187@SHSMSX101.ccr.corp.intel.com> References: <1416386354-18274-1-git-send-email-zhida.zang@intel.com> <533710CFB86FA344BFBF2D6802E60286C98A63@SHSMSX101.ccr.corp.intel.com> <928962E22C65404992AE807B3659CED6BFB898@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <928962E22C65404992AE807B3659CED6BFB898@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e: fixed tx stats bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2014 02:12:35 -0000 Yes, but I think it is better for you to made a v2 patch Thanks Michael -----Original Message----- From: Zang, Zhida=20 Sent: Thursday, November 20, 2014 9:15 AM To: Qiu, Michael; dev@dpdk.org Subject: RE: [dpdk-dev] [PATCH] i40e: fixed tx stats bug Is that OK that I send another patch with details directly? -----Original Message----- From: Qiu, Michael Sent: Wednesday, November 19, 2014 17:27 To: Zang, Zhida; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: fixed tx stats bug On 11/19/2014 4:43 PM, zhida zang wrote: > From: zzang > > Fixed tx stats bug in i40e Would you mind to give more details about this bug in the commit log? This can really help reviewer to get the initial idea about your patch wit= hout go through the code it self. Thanks, Michael > > Signed-off-by: zzang > --- > lib/librte_pmd_i40e/i40e_ethdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c > b/lib/librte_pmd_i40e/i40e_ethdev.c > index 4b7a827..e01590c 100644 > --- a/lib/librte_pmd_i40e/i40e_ethdev.c > +++ b/lib/librte_pmd_i40e/i40e_ethdev.c > @@ -1102,6 +1102,7 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct = rte_eth_stats *stats) > struct i40e_hw *hw =3D I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); > struct i40e_hw_port_stats *ns =3D &pf->stats; /* new stats */ > struct i40e_hw_port_stats *os =3D &pf->stats_offset; /* old stats */ > + struct i40e_eth_stats *ves =3D &pf->main_vsi->eth_stats; /* vsi stats=20 > +*/ > =20 > /* Get statistics of struct i40e_eth_stats */ > i40e_stat_update_48(hw, I40E_GLPRT_GORCH(hw->port), @@ -1284,8 > +1285,8 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct > rte_eth_stats *stats) > =20 > stats->ipackets =3D ns->eth.rx_unicast + ns->eth.rx_multicast + > ns->eth.rx_broadcast; > - stats->opackets =3D ns->eth.tx_unicast + ns->eth.tx_multicast + > - ns->eth.tx_broadcast; > + stats->opackets =3D ves->tx_unicast + ves->tx_multicast + > + ves->tx_broadcast; > stats->ibytes =3D ns->eth.rx_bytes; > stats->obytes =3D ns->eth.tx_bytes; > stats->oerrors =3D ns->eth.tx_errors;