From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B84D37F0C for ; Fri, 21 Nov 2014 07:44:31 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 20 Nov 2014 22:55:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,429,1413270000"; d="scan'208";a="626031362" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga001.fm.intel.com with ESMTP; 20 Nov 2014 22:54:49 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 21 Nov 2014 14:54:30 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.86]) with mapi id 14.03.0195.001; Fri, 21 Nov 2014 14:54:29 +0800 From: "Qiu, Michael" To: "Liu, Jijiang" , "Zang, Zhida" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] i40e: fixed tx packets stats bug Thread-Index: AQHQBJ2jdJCDUAcQpUOeNdJ/uvwXJg== Date: Fri, 21 Nov 2014 06:54:28 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286C996A4@SHSMSX101.ccr.corp.intel.com> References: <1416472802-8225-1-git-send-email-zhida.zang@intel.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9D71A@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] i40e: fixed tx packets stats bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2014 06:44:32 -0000 On 2014/11/21 14:33, Liu, Jijiang wrote:=0A= > This patch V2 updated commit log.=0A= =0A= Not only updated commit log, but also the code :)=0A= =0A= Thanks,=0A= Michael=0A= >=0A= >> -----Original Message-----=0A= >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhida zang=0A= >> Sent: Thursday, November 20, 2014 4:40 PM=0A= >> To: dev@dpdk.org=0A= >> Subject: [dpdk-dev] [PATCH v2] i40e: fixed tx packets stats bug=0A= >>=0A= >> From: zzang =0A= >>=0A= >> i40e only count tx packets that sent by pf. But in some condition packet= can be=0A= >> sent by NIC without being counted by pf. So count vsi tx packets instead= .=0A= >>=0A= >> Signed-off-by: zhida zang =0A= >> ---=0A= >> lib/librte_pmd_i40e/i40e_ethdev.c | 10 +++++++---=0A= >> 1 file changed, 7 insertions(+), 3 deletions(-)=0A= >>=0A= >> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c=0A= >> b/lib/librte_pmd_i40e/i40e_ethdev.c=0A= >> index 4b7a827..c1ea37e 100644=0A= >> --- a/lib/librte_pmd_i40e/i40e_ethdev.c=0A= >> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c=0A= >> @@ -1102,6 +1102,7 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct= =0A= >> rte_eth_stats *stats)=0A= >> struct i40e_hw *hw =3D I40E_DEV_PRIVATE_TO_HW(dev->data-=0A= >>> dev_private);=0A= >> struct i40e_hw_port_stats *ns =3D &pf->stats; /* new stats */=0A= >> struct i40e_hw_port_stats *os =3D &pf->stats_offset; /* old stats */= =0A= >> + struct i40e_eth_stats *ves =3D &pf->main_vsi->eth_stats; /* vsi stats = */=0A= >>=0A= >> /* Get statistics of struct i40e_eth_stats */=0A= >> i40e_stat_update_48(hw, I40E_GLPRT_GORCH(hw->port), @@ -1277,15=0A= >> +1278,18 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_s= tats=0A= >> *stats)=0A= >> /* GLPRT_MSPDC not supported */=0A= >> /* GLPRT_XEC not supported */=0A= >>=0A= >> - pf->offset_loaded =3D true;=0A= >> -=0A= >> if (pf->main_vsi)=0A= >> i40e_update_vsi_stats(pf->main_vsi);=0A= >>=0A= >> stats->ipackets =3D ns->eth.rx_unicast + ns->eth.rx_multicast +=0A= >> ns->eth.rx_broadcast;=0A= >> - stats->opackets =3D ns->eth.tx_unicast + ns->eth.tx_multicast +=0A= >> + if (pf->offset_loaded)=0A= >> + stats->opackets =3D ves->tx_unicast + ves->tx_multicast +=0A= >> + ves->tx_broadcast;=0A= >> + else=0A= >> + stats->opackets =3D ns->eth.tx_unicast + ns->eth.tx_multicast +=0A= >> ns->eth.tx_broadcast;=0A= >> + pf->offset_loaded =3D true;=0A= >> stats->ibytes =3D ns->eth.rx_bytes;=0A= >> stats->obytes =3D ns->eth.tx_bytes;=0A= >> stats->oerrors =3D ns->eth.tx_errors;=0A= >> --=0A= >> 1.9.3=0A= > Acked-by: Jijiang Liu < Jijiang.liu@intel.com>=0A= >=0A= =0A=