From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3542D7EB0 for ; Tue, 2 Dec 2014 08:04:33 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 01 Dec 2014 23:01:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,499,1413270000"; d="scan'208";a="631190892" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga001.fm.intel.com with ESMTP; 01 Dec 2014 23:01:39 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 2 Dec 2014 14:58:36 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.86]) with mapi id 14.03.0195.001; Tue, 2 Dec 2014 14:58:31 +0800 From: "Qiu, Michael" To: "Zhang, Helin" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] i40e: bug fix of compile error Thread-Index: AQHQDTlYIrgbkTVoBky9G/lz1blIYw== Date: Tue, 2 Dec 2014 06:58:30 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286C9BECF@SHSMSX101.ccr.corp.intel.com> References: <1417419227-21465-1-git-send-email-helin.zhang@intel.com> <2036571.ijmOSAQnXA@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: multipart/mixed; boundary="_002_533710CFB86FA344BFBF2D6802E60286C9BECFSHSMSX101ccrcorpi_" MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Dec 2014 07:04:34 -0000 --_002_533710CFB86FA344BFBF2D6802E60286C9BECFSHSMSX101ccrcorpi_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On 12/2/2014 8:36 AM, Zhang, Helin wrote:=0A= >=0A= >> -----Original Message-----=0A= >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=0A= >> Sent: Monday, December 1, 2014 7:13 PM=0A= >> To: Zhang, Helin=0A= >> Cc: dev@dpdk.org=0A= >> Subject: Re: [dpdk-dev] [PATCH] i40e: bug fix of compile error=0A= >>=0A= >> 2014-12-01 15:33, Helin Zhang:=0A= >>> The compile error will occur as below when set=0A= >> 'RTE_LIBRTE_I40E_16BYTE_RX_DESC=3Dy'.=0A= >>> The changes is just to fix it.=0A= >>>=0A= >>> lib/librte_pmd_i40e/i40e_rxtx.c: In function i40e_rxd_build_fdir:=0A= >>> lib/librte_pmd_i40e/i40e_rxtx.c:431:28: error: volatile union=0A= >>> has no member named fd=0A= >>> lib/librte_pmd_i40e/i40e_rxtx.c:427:19: error: unused variable flexbl= =0A= >>> [-Werror=3Dunused-variable]=0A= >>> lib/librte_pmd_i40e/i40e_rxtx.c:427:11: error: unused variable flexbh= =0A= >>> [-Werror=3Dunused-variable]=0A= >> It would be nice to reference the commit which introduced the error and = explain=0A= >> it a bit.=0A= >>=0A= >>> - rte_le_to_cpu_32(rxdp->wb.qword3.hi_dword.flex_bytes_hi);=0A= >>> + rte_le_to_cpu_32(=0A= >>> + rxdp->wb.qword3.hi_dword.flex_bytes_hi);=0A= >> [...]=0A= >>> - rte_le_to_cpu_32(rxdp->wb.qword3.lo_dword.flex_bytes_lo);=0A= >>> + rte_le_to_cpu_32(=0A= >>> + rxdp->wb.qword3.lo_dword.flex_bytes_lo);=0A= >> Why are you wrapping these lines (with wrong indentation)?=0A= >> It makes the fix confuse.=0A= > Sorry, it is a code style fix, as the length of the line should not be mo= re than 80.=0A= > Do I need to split the patch or add more commit logs?=0A= =0A= I think this coding style fix is not good enough,=0A= =0A= mb->hash.fdir.hi =3D rte_le_to_cpu_32(rxdp->wb.qword3=0A= .hi_dword.fd_id);=0A= =0A= This would be better :)=0A= =0A= See the attached diff file, so sorry I indeed do not know how to add=0A= diff file in the email(except git send-email), So I just attached it.=0A= =0A= >=0A= >> --=0A= >> Thomas=0A= > Regards,=0A= > Helin=0A= >=0A= =0A= --_002_533710CFB86FA344BFBF2D6802E60286C9BECFSHSMSX101ccrcorpi_ Content-Type: text/plain; name="diff_code_style_fix" Content-Description: diff_code_style_fix Content-Disposition: attachment; filename="diff_code_style_fix"; size=1471; creation-date="Tue, 02 Dec 2014 06:58:30 GMT"; modification-date="Tue, 02 Dec 2014 06:58:30 GMT" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYi9saWJydGVfcG1kX2k0MGUvaTQwZV9yeHR4LmMgYi9saWIvbGlicnRl X3BtZF9pNDBlL2k0MGVfcnh0eC5jCmluZGV4IDJkMmVmMDQuLmUwMjY0ZmMgMTAwNjQ0Ci0tLSBh L2xpYi9saWJydGVfcG1kX2k0MGUvaTQwZV9yeHR4LmMKKysrIGIvbGliL2xpYnJ0ZV9wbWRfaTQw ZS9pNDBlX3J4dHguYwpAQCAtNDI3LDggKzQyNyw3IEBAIGk0MGVfcnhkX2J1aWxkX2ZkaXIodm9s YXRpbGUgdW5pb24gaTQwZV9yeF9kZXNjICpyeGRwLCBzdHJ1Y3QgcnRlX21idWYgKm1iKQogCXVp bnQxNl90IGZsZXhiaCwgZmxleGJsOwogCiAjaWZkZWYgUlRFX0xJQlJURV9JNDBFXzE2QllURV9S WF9ERVNDCi0JbWItPmhhc2guZmRpci5oaSA9Ci0JCXJ0ZV9sZV90b19jcHVfMzIocnhkcC0+d2Iu cXdvcmQwLmhpX2R3b3JkLmZkKTsKKwltYi0+aGFzaC5mZGlyLmhpID0gcnRlX2xlX3RvX2NwdV8z MihyeGRwLT53Yi5xd29yZDAuaGlfZHdvcmQuZmQpOwogCWZsYWdzIHw9IFBLVF9SWF9GRElSX0lE OwogI2Vsc2UKIAlmbGV4YmggPSAocnRlX2xlX3RvX2NwdV8zMihyeGRwLT53Yi5xd29yZDIuZXh0 X3N0YXR1cykgPj4KQEAgLTQ0MCwxNyArNDM5LDE3IEBAIGk0MGVfcnhkX2J1aWxkX2ZkaXIodm9s YXRpbGUgdW5pb24gaTQwZV9yeF9kZXNjICpyeGRwLCBzdHJ1Y3QgcnRlX21idWYgKm1iKQogCiAK IAlpZiAoZmxleGJoID09IEk0MEVfUlhfREVTQ19FWFRfU1RBVFVTX0ZMRVhCSF9GRF9JRCkgewot CQltYi0+aGFzaC5mZGlyLmhpID0KLQkJCXJ0ZV9sZV90b19jcHVfMzIocnhkcC0+d2IucXdvcmQz LmhpX2R3b3JkLmZkX2lkKTsKKwkJbWItPmhhc2guZmRpci5oaSA9IHJ0ZV9sZV90b19jcHVfMzIo cnhkcC0+d2IucXdvcmQzCisJCQkJCQkgICAgLmhpX2R3b3JkLmZkX2lkKTsKIAkJZmxhZ3MgfD0g UEtUX1JYX0ZESVJfSUQ7CiAJfSBlbHNlIGlmIChmbGV4YmggPT0gSTQwRV9SWF9ERVNDX0VYVF9T VEFUVVNfRkxFWEJIX0ZMRVgpIHsKLQkJbWItPmhhc2guZmRpci5oaSA9Ci0JCQlydGVfbGVfdG9f Y3B1XzMyKHJ4ZHAtPndiLnF3b3JkMy5oaV9kd29yZC5mbGV4X2J5dGVzX2hpKTsKKwkJbWItPmhh c2guZmRpci5oaSA9IHJ0ZV9sZV90b19jcHVfMzIocnhkcC0+d2IucXdvcmQzCisJCQkJCQkgICAg LmhpX2R3b3JkLmZsZXhfYnl0ZXNfaGkpOwogCQlmbGFncyB8PSBQS1RfUlhfRkRJUl9GTFg7CiAJ fQogCWlmIChmbGV4YmwgPT0gSTQwRV9SWF9ERVNDX0VYVF9TVEFUVVNfRkxFWEJMX0ZMRVgpIHsK LQkJbWItPmhhc2guZmRpci5sbyA9Ci0JCQlydGVfbGVfdG9fY3B1XzMyKHJ4ZHAtPndiLnF3b3Jk My5sb19kd29yZC5mbGV4X2J5dGVzX2xvKTsKKwkJbWItPmhhc2guZmRpci5sbyA9IHJ0ZV9sZV90 b19jcHVfMzIocnhkcC0+d2IucXdvcmQzCisJCQkJCQkgICAgLmxvX2R3b3JkLmZsZXhfYnl0ZXNf bG8pOwogCQlmbGFncyB8PSBQS1RfUlhfRkRJUl9GTFg7CiAJfQogI2VuZGlmCg== --_002_533710CFB86FA344BFBF2D6802E60286C9BECFSHSMSX101ccrcorpi_--