From: "Qiu, Michael" <michael.qiu@intel.com>
To: Michael Qiu <qdy220091330@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] test-pmd: Fix "__BYTE_ORDER__" not defined error
Date: Wed, 3 Dec 2014 16:26:02 +0000 [thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286C9C636@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1417606044-3432-1-git-send-email-michael.qiu@intel.com>
Hi all,
What about this patch?
It may be some network or mail client issue of me, so not sure this
patch posted to mail list successful.
If failed, I will re-post it later.
Thanks,
Michael
On 2014/12/3 19:28, Michael Qiu wrote:
> app/test-pmd/csumonly.c:84:5: error: "__BYTE_ORDER__" is not defined
> app/test-pmd/csumonly.c:84:23: error: "__ORDER_LITTLE_ENDIAN__" is not defined
>
> This because old gcc version, like 4.4.7, does not has these buildin macros.
>
> $ gcc -v
> Using built-in specs.
> Target: x86_64-redhat-linux
> ...
> gcc version 4.4.7 20120313 (Red Hat 4.4.7-4) (GCC)
>
> $ echo | gcc -dM -E -| grep "LITTLE"
> (none)
>
> In this situation, we should back to use the macros defined in
> <endian.h>
>
> Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> ---
> app/test-pmd/csumonly.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> index 6f43761..3fa81a2 100644
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -81,7 +81,13 @@
>
> /* we cannot use htons() from arpa/inet.h due to name conflicts, and we
> * cannot use rte_cpu_to_be_16() on a constant in a switch/case */
> -#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
> +#ifdef __BYTE_ORDER__
> +#define LITTLE_ENDIAN_CHECK (__BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__)
> +#else
> +#define LITTLE_ENDIAN_CHECK (__BYTE_ORDER == __LITTLE_ENDIAN)
> +#endif
> +
> +#if LITTLE_ENDIAN_CHECK
> #define _htons(x) ((uint16_t)((((x) & 0x00ffU) << 8) | (((x) & 0xff00U) >> 8)))
> #else
> #define _htons(x) (x)
next prev parent reply other threads:[~2014-12-03 19:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1417606044-3432-1-git-send-email-michael.qiu@intel.com>
[not found] ` <1417606099-3489-1-git-send-email-michael.qiu@intel.com>
2014-12-03 11:42 ` [dpdk-dev] [PATCH] test-pmd: Fix pointer aliasing error Bruce Richardson
2014-12-03 13:59 ` Qiu, Michael
2014-12-03 14:51 ` Bruce Richardson
2014-12-03 15:19 ` Qiu, Michael
2014-12-03 15:36 ` Bruce Richardson
2014-12-04 2:38 ` Qiu, Michael
2014-12-04 3:28 ` [dpdk-dev] [PATCH v2] " Michael Qiu
2014-12-04 4:16 ` [dpdk-dev] [PATCH v3] " Michael Qiu
2014-12-05 5:34 ` Qiu, Michael
2014-12-05 9:24 ` Thomas Monjalon
2014-12-08 1:28 ` Qiu, Michael
2014-12-08 1:30 ` Qiu, Michael
2014-12-10 3:44 ` Qiu, Michael
2014-12-11 0:54 ` Thomas Monjalon
2014-12-11 17:51 ` r k
2014-12-12 6:49 ` Qiu, Michael
2014-12-04 12:54 ` [dpdk-dev] [PATCH v2] " Ananyev, Konstantin
2014-12-03 15:24 ` [dpdk-dev] [PATCH] " Olivier MATZ
2014-12-03 16:03 ` Dayu Qiu
2014-12-03 15:57 ` Dayu Qiu
2014-12-03 16:26 ` Qiu, Michael [this message]
2014-12-03 19:59 ` [dpdk-dev] [PATCH] test-pmd: Fix "__BYTE_ORDER__" not defined error Thomas Monjalon
2014-12-03 20:47 ` [dpdk-dev] [PATCH 0/2] fix endianness in EAL Thomas Monjalon
2014-12-03 20:47 ` [dpdk-dev] [PATCH 1/2] eal: detect endianness Thomas Monjalon
2014-12-04 2:28 ` Qiu, Michael
2014-12-04 9:00 ` Thomas Monjalon
2014-12-04 10:28 ` Qiu, Michael
2014-12-04 12:19 ` Thomas Monjalon
2014-12-04 12:50 ` Qiu, Michael
2014-12-03 20:47 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix endianness detection Thomas Monjalon
2014-12-04 9:28 ` [dpdk-dev] [PATCH 0/2] fix endianness in EAL Chao Zhu
2014-12-05 16:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533710CFB86FA344BFBF2D6802E60286C9C636@SHSMSX101.ccr.corp.intel.com \
--to=michael.qiu@intel.com \
--cc=dev@dpdk.org \
--cc=qdy220091330@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).