From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8685E3F9 for ; Tue, 9 Dec 2014 17:04:36 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 09 Dec 2014 08:01:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="496094085" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga003.jf.intel.com with ESMTP; 09 Dec 2014 07:59:21 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 10 Dec 2014 00:03:02 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by shsmsx102.ccr.corp.intel.com ([169.254.2.216]) with mapi id 14.03.0195.001; Wed, 10 Dec 2014 00:03:01 +0800 From: "Qiu, Michael" To: "Ouyang, Changchun" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [RFC PATCH 00/17] Single virtio implementation Thread-Index: AQHQEq+Q2Lq/26W45UWXqeMFusY+cw== Date: Tue, 9 Dec 2014 16:03:01 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286C9E267@SHSMSX101.ccr.corp.intel.com> References: <1418019716-4962-1-git-send-email-changchun.ouyang@intel.com> <533710CFB86FA344BFBF2D6802E60286C9DE44@SHSMSX101.ccr.corp.intel.com> <1941671.RlrZxTondI@xps13> <20141209094658.GA9472@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single virtio implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Dec 2014 16:04:37 -0000 On 2014/12/9 22:19, Ouyang, Changchun wrote:=0A= > Hi Bruce,=0A= >=0A= >> -----Original Message-----=0A= >> From: Richardson, Bruce=0A= >> Sent: Tuesday, December 9, 2014 5:47 PM=0A= >> To: Ouyang, Changchun=0A= >> Cc: Thomas Monjalon; dev@dpdk.org=0A= >> Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single virtio implementation= =0A= >>=0A= >> On Tue, Dec 09, 2014 at 06:40:23AM +0000, Ouyang, Changchun wrote:=0A= >>>=0A= >>>> -----Original Message-----=0A= >>>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=0A= >>>> Sent: Tuesday, December 9, 2014 2:12 PM=0A= >>>> To: Ouyang, Changchun=0A= >>>> Cc: Qiu, Michael; Stephen Hemminger; dev@dpdk.org=0A= >>>> Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single virtio=0A= >>>> implementation=0A= >>>>=0A= >>>> 2014-12-09 05:41, Ouyang, Changchun:=0A= >>>>> Hi=0A= >>>>>=0A= >>>>>> -----Original Message-----=0A= >>>>>> From: Qiu, Michael=0A= >>>>>> Sent: Tuesday, December 9, 2014 11:23 AM=0A= >>>>>> To: Ouyang, Changchun; Thomas Monjalon; Stephen Hemminger=0A= >>>>>> Cc: dev@dpdk.org=0A= >>>>>> Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single virtio=0A= >>>>>> implementation=0A= >>>>>>=0A= >>>>>> On 12/9/2014 9:11 AM, Ouyang, Changchun wrote:=0A= >>>>>>> Hi Thomas,=0A= >>>>>>>=0A= >>>>>>>> -----Original Message-----=0A= >>>>>>>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=0A= >>>>>>>> Sent: Monday, December 8, 2014 5:31 PM=0A= >>>>>>>> To: Ouyang, Changchun=0A= >>>>>>>> Cc: dev@dpdk.org=0A= >>>>>>>> Subject: Re: [dpdk-dev] [RFC PATCH 00/17] Single virtio=0A= >>>>>>>> implementation=0A= >>>>>>>>=0A= >>>>>>>> Hi Changchun,=0A= >>>>>>>>=0A= >>>>>>>> 2014-12-08 14:21, Ouyang Changchun:=0A= >>>>>>>>> This patch set bases on two original RFC patch sets from=0A= >>>>>>>>> Stephen=0A= >>>>>>>> Hemminger[stephen@networkplumber.org]=0A= >>>>>>>>> Refer to=0A= >>>>>>>>> [http://dpdk.org/ml/archives/dev/2014-August/004845.html ]=0A= >>>>>>>>> for=0A= >>>>>>>> the original one.=0A= >>>>>>>>> This patch set also resolves some conflict with latest codes=0A= >>>>>>>>> and removed=0A= >>>>>>>> duplicated codes.=0A= >>>>>>>>=0A= >>>>>>>> As you sent the patches, you appear as the author.=0A= >>>>>>>> But I guess Stephen should be the author for some of them.=0A= >>>>>>>> Please check who has contributed the most in each patch to=0A= >> decide.=0A= >>>>>>> You are right, most of patches originate from Stephen's=0A= >>>>>>> patchset, except for the last one, To be honest, I am ok=0A= >>>>>>> whoever is the author of this patch set, :-), We could co-own=0A= >>>>>>> the feature of Single virtio if you all agree with it, and I=0A= >>>>>>> think we couldn't finish Such a feature without collaboration=0A= >>>>>>> among us, this is why I tried to communicate=0A= >>>>>> with most of you to collect more feedback, suggestion and=0A= >>>>>> comments for this feature.=0A= >>>>>>> Very appreciate for all kinds of feedback, suggestion here,=0A= >>>>>>> especially for=0A= >>>>>> patch set from Stephen.=0A= >>>>>>> According to your request, how could we make this patch set=0A= >>>>>>> looks more=0A= >>>>>> like Stephen as the author?=0A= >>>>>>> Currently I add Stephen as Signed-off-by list in each patch(I=0A= >>>>>>> got the=0A= >>>>>> agreement from Stephen before doing this :-)).=0A= >>>>>>=0A= >>>>>> Hi Ouyang,=0A= >>>>>>=0A= >>>>>> "Signed-off-by" should be added by himself, because the one who=0A= >>>>>> in the Signed-off-by list should take responsibility for it(like=0A= >>>>>> potential=0A= >>>> bugs/issues).=0A= >>>>>> Although, lots of patches are originate from Stephen, we still=0A= >>>>>> need himself add this line :)=0A= >>>>> Hi Thomas,=0A= >>>>> It that right? I can't add Stephen into Signed-off-by list even if=0A= >>>>> I have gotten the agreement from Stephen, What 's the strict rule her= e?=0A= >>>> Stephen sent the patches with his Signed-off, then you added yours.=0A= >>>> This is OK.=0A= >>>> Using git am, author would have been Stephen. To change author now,=0A= >>>> you can edit each commit with interactive rebase and "git commit=0A= >>>> --amend -- author=3DStephen".=0A= >>>> No need to resend now. Please check it for next version of the patchse= t.=0A= >>>>=0A= >>> So I understand correctly, Stephen need care for from patches from 1=0A= >>> to 16, I need care for the 17th patch from next version.=0A= >>> What I mean "caring for" above is: debug and validate them and send=0A= >>> out patches=0A= >>>=0A= >>> Thanks=0A= >>> Changchun=0A= >>>=0A= >> Just to clarify Thomas point here about use of "git am". If you get a pa= tch=0A= >> from someone to test or work on, use "git am" to apply it, rather than "= git=0A= >> apply", since "git am" generates a commit in your local repo and thereby= =0A= >> maintains the original authorship of the patch. If you do "git apply" an= d=0A= >> subsequently commit yourself, you - rather than the original author - wi= ll=0A= >> appear as the "author" of the patch, and you need to amend the commit as= =0A= >> Thomas suggests to fix this.=0A= >>=0A= >> So in short:=0A= >> * git am =3D=3D good=0A= >> * git apply =3D=3D bad=0A= > Thanks very much for the clarification. I will use git am for next versio= n.=0A= =0A= BTW, you also can use "git am ./xx/*" to patch a series patch set to=0A= your local git tree.=0A= =0A= Thanks,=0A= Michael=0A= > Changchun=0A= >=0A= >=0A= =0A=