From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 979347DF0 for ; Thu, 18 Dec 2014 14:46:00 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 18 Dec 2014 05:45:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="500914980" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga003.jf.intel.com with ESMTP; 18 Dec 2014 05:41:38 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 18 Dec 2014 21:45:57 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by shsmsx102.ccr.corp.intel.com ([169.254.2.216]) with mapi id 14.03.0195.001; Thu, 18 Dec 2014 21:45:56 +0800 From: "Qiu, Michael" To: Neil Horman , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] xenvirt: Fix build break on cmdline_parse_etheraddr call Thread-Index: AQHQGrZUOOvk3QY+8Emq2i0caRo1Mg== Date: Thu, 18 Dec 2014 13:45:54 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CA0ECB@SHSMSX101.ccr.corp.intel.com> References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com> <1418902316-30266-1-git-send-email-nhorman@tuxdriver.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] xenvirt: Fix build break on cmdline_parse_etheraddr call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 13:46:01 -0000 Hi Neil,=0A= =0A= I think if you could add the commit author in the cc list will be better.= =0A= =0A= Because this could let him know about his code's issue and he is the=0A= always the best person to review the patch.=0A= =0A= Thanks,=0A= Michael=0A= =0A= On 2014/12/18 19:32, Neil Horman wrote:=0A= > Back in:=0A= >=0A= > commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db=0A= > Author: Alan Carew =0A= > Date: Fri Dec 5 15:19:07 2014 +0100=0A= >=0A= > cmdline: fix overflow on bsd=0A= >=0A= > The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. = This=0A= > patch makes the needed correction to avoid a build break=0A= >=0A= > Signed-off-by: Neil Horman =0A= > CC: Thomas Monjalon =0A= > CC: Olivier Matz =0A= >=0A= > ---=0A= > Change notes=0A= >=0A= > v2: Changed sizeof(struct ether_addr) to sizeof(dict->addr)=0A= > ---=0A= > lib/librte_pmd_xenvirt/rte_eth_xenvirt.c | 5 +++--=0A= > 1 file changed, 3 insertions(+), 2 deletions(-)=0A= >=0A= > diff --git a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c b/lib/librte_pmd_xe= nvirt/rte_eth_xenvirt.c=0A= > index 6555ec5..04e30c9 100644=0A= > --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c=0A= > +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c=0A= > @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict,= =0A= > if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM,=0A= > sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) {=0A= > if (cmdline_parse_etheraddr(NULL,=0A= > - pair[1],=0A= > - &dict->addr) < 0) {=0A= > + pair[1],=0A= > + &dict->addr,=0A= > + sizeof(dict->addr)) < 0) {=0A= > RTE_LOG(ERR, PMD,=0A= > "Invalid %s device ether address\n",=0A= > name);=0A= =0A=