From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B747268AA for ; Thu, 18 Dec 2014 14:51:18 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 18 Dec 2014 05:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,601,1413270000"; d="scan'208";a="639705379" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by fmsmga001.fm.intel.com with ESMTP; 18 Dec 2014 05:51:16 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 18 Dec 2014 21:51:15 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by shsmsx102.ccr.corp.intel.com ([169.254.2.216]) with mapi id 14.03.0195.001; Thu, 18 Dec 2014 21:51:14 +0800 From: "Qiu, Michael" To: Neil Horman , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call Thread-Index: AQHQGhvN8ziGS8lIdk+UUNn+59Vvog== Date: Thu, 18 Dec 2014 13:51:13 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CA0EE5@SHSMSX101.ccr.corp.intel.com> References: <1418835808-18803-1-git-send-email-nhorman@tuxdriver.com> <2522675.0gKbYfjInz@xps13> <20141218112523.GA18008@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 13:51:19 -0000 On 2014/12/18 19:26, Neil Horman wrote:=0A= > On Wed, Dec 17, 2014 at 11:20:26PM +0100, Thomas Monjalon wrote:=0A= >> Hi Neil,=0A= >>=0A= >> 2014-12-17 12:03, Neil Horman:=0A= >>> Back in:=0A= >>>=0A= >>> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db=0A= >>> Author: Alan Carew =0A= >>> Date: Fri Dec 5 15:19:07 2014 +0100=0A= >>>=0A= >>> cmdline: fix overflow on bsd=0A= >>>=0A= >>> The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt= . This=0A= >>> patch makes the needed correction to avoid a build break=0A= >>>=0A= >>> Signed-off-by: Neil Horman =0A= >>> CC: Thomas Monjalon =0A= >> What is the meaning of CC here?=0A= >>=0A= > CC is a tag that git send-email understands. As it implies it cc's the p= ost to=0A= > the indicated email, and records that fact in the body of the commit.=0A= =0A= But if you use --cc in git send-email will be a good choice. CC list is=0A= useless for patch it self, but here it will exist in commit log(although=0A= this style can also be seen in linux kernel)=0A= =0A= Thanks,=0A= Michael=0A= >>> --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c=0A= >>> +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c=0A= >>> @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dic= t,=0A= >>> if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM,=0A= >>> sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) {=0A= >>> if (cmdline_parse_etheraddr(NULL,=0A= >>> - pair[1],=0A= >>> - &dict->addr) < 0) {=0A= >>> + pair[1],=0A= >>> + &dict->addr,=0A= >>> + sizeof(struct ether_addr)) < 0) {=0A= >> Why not sizeof(dict->addr)?=0A= >>=0A= > Because addr is a struct ether_addr, and I always get confused when doing= sizeof=0A= > on pointer variables, so I find it more clear to specify the type exactly= . I'm=0A= > not bound to it though so if you like I can change it, though given its r= elease=0A= > day, I figure you want to fix this build break asap.=0A= > Neil=0A= >=0A= >> -- =0A= >> Thomas=0A= >>=0A= =0A=