Re: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API

["Qiu, Michael" <michael.qiu@intel.com>]

Hi Jingjing,

Would you mind to tell me why need new APIs? Any functional or
performance increase?
Better to state in commit log.

You know it should be careful to change APIs, especially for user
interface. 

Thanks,
Michael
On 12/25/2014 11:14 AM, Jingjing Wu wrote:
> The patch set uses new filter_ctrl API to replace old ethertype filter APIs.
> It uses new functions and structure to replace old ones in igb/ixgbe driver,
> new commands to replace old ones in testpmd, and removes the old APIs. 
>
> Jingjing Wu (4):
>   ixgbe: new functions replaces old ones for ethertype filters
>   e1000: new functions replaces old ones for ethertype filters
>   testpmd: new commands for ethertype filter
>   ethdev: remove old APIs and structures of ethertype filters
>
>  app/test-pmd/cmdline.c              | 253 ++++++++++++--------------
>  app/test-pmd/config.c               |  27 ---
>  lib/librte_ether/rte_ethdev.c       |  57 ------
>  lib/librte_ether/rte_ethdev.h       |  88 ---------
>  lib/librte_pmd_e1000/e1000_ethdev.h |  13 ++
>  lib/librte_pmd_e1000/igb_ethdev.c   | 332 +++++++++++++++++++++------------
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 354 +++++++++++++++++++++++-------------
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  13 ++
>  8 files changed, 579 insertions(+), 558 deletions(-)
>