From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DFC0919F5 for ; Thu, 25 Dec 2014 05:57:22 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 24 Dec 2014 20:55:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="433190231" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by FMSMGA003.fm.intel.com with ESMTP; 24 Dec 2014 20:45:43 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 25 Dec 2014 12:57:14 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.182]) with mapi id 14.03.0195.001; Thu, 25 Dec 2014 12:57:13 +0800 From: "Qiu, Michael" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API Thread-Index: AQHQH/D3zsuN0/0nzkaSTMZmTI5IAw== Date: Thu, 25 Dec 2014 04:57:12 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CA2870@SHSMSX101.ccr.corp.intel.com> References: <1419477270-14611-1-git-send-email-jingjing.wu@intel.com> <533710CFB86FA344BFBF2D6802E60286CA27E3@SHSMSX101.ccr.corp.intel.com> <9BB6961774997848B5B42BEC655768F8B6561A@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Dec 2014 04:57:23 -0000 On 12/25/2014 11:39 AM, Wu, Jingjing wrote:=0A= > Hi, Michael=0A= >=0A= > It's a long discuss in community.=0A= >=0A= > Due to in the development in i40e driver, we defined a new common API use= d for kinds of filters. In R1.8, because of time limit and compatibility, w= e just used the new API for i40e driver. While other driver still use old o= nes.=0A= > We have planned to integrate filter to this new API to make the APIs gene= ric for different types of NICs.=0A= =0A= OK, got it, sorry for missing the old thread :)=0A= =0A= If you will have new version patch, I would like you add the statement=0A= to the commit log, it could be better for other to understand why :)=0A= =0A= Thanks,=0A= Michael=0A= > Jingjing=0A= >=0A= >=0A= >> -----Original Message-----=0A= >> From: Qiu, Michael=0A= >> Sent: Thursday, December 25, 2014 11:27 AM=0A= >> To: Wu, Jingjing; dev@dpdk.org=0A= >> Subject: Re: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ix= gbe=0A= >> driver to new API=0A= >>=0A= >> Hi Jingjing,=0A= >>=0A= >> Would you mind to tell me why need new APIs? Any functional or=0A= >> performance increase?=0A= >> Better to state in commit log.=0A= >>=0A= >> You know it should be careful to change APIs, especially for user interf= ace.=0A= >>=0A= >> Thanks,=0A= >> Michael=0A= >> On 12/25/2014 11:14 AM, Jingjing Wu wrote:=0A= >>> The patch set uses new filter_ctrl API to replace old ethertype filter = APIs.=0A= >>> It uses new functions and structure to replace old ones in igb/ixgbe=0A= >>> driver, new commands to replace old ones in testpmd, and removes the=0A= >> old APIs.=0A= >>> Jingjing Wu (4):=0A= >>> ixgbe: new functions replaces old ones for ethertype filters=0A= >>> e1000: new functions replaces old ones for ethertype filters=0A= >>> testpmd: new commands for ethertype filter=0A= >>> ethdev: remove old APIs and structures of ethertype filters=0A= >>>=0A= >>> app/test-pmd/cmdline.c | 253 ++++++++++++--------------= =0A= >>> app/test-pmd/config.c | 27 ---=0A= >>> lib/librte_ether/rte_ethdev.c | 57 ------=0A= >>> lib/librte_ether/rte_ethdev.h | 88 ---------=0A= >>> lib/librte_pmd_e1000/e1000_ethdev.h | 13 ++=0A= >>> lib/librte_pmd_e1000/igb_ethdev.c | 332 +++++++++++++++++++++-----= =0A= >> -------=0A= >>> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 354=0A= >>> +++++++++++++++++++++++-------------=0A= >>> lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 13 ++=0A= >>> 8 files changed, 579 insertions(+), 558 deletions(-)=0A= >>>=0A= >=0A= =0A=