From: "Qiu, Michael" <michael.qiu@intel.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2
Date: Mon, 19 Jan 2015 10:02:12 +0000 [thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286CB753D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <CALwxeUvjjJV_vdPYfyCnQSM_m4x2YtizNW3-BXz8K0Tprd3Yhg@mail.gmail.com>
On 2015/1/19 17:50, David Marchand wrote:
On Mon, Jan 19, 2015 at 10:30 AM, Qiu, Michael <michael.qiu@intel.com<mailto:michael.qiu@intel.com>> wrote:
This could be, but I hope every contributor could do basic check like
build and run of at lease one app like test-pmd, then it will reduce
most of failure we faced.
testpmd is fine, but make test should be preferred as it requires no setup and it requires no pmd to be configured.
Besides, testpmd is an application, it does not test libraries that it does not use, while make test is supposed to test all libraries.
I just use test-pmd for an example, the contributor should test his patches before send out, especially, the test need to focus on what he try to fixed.
It is a bad behavior to send out before test.
There is still the hugepages to configure when running make test so I would say "make test" should tell you so.
This will avoid wasting 10 minutes to understand why all your tests fail ...
Can anyone help document this / make it more user friendly / easier ?
--
David Marchand
next prev parent reply other threads:[~2015-01-19 10:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-27 15:28 Ravi Kerur
2014-12-27 15:30 ` Ravi Kerur
2014-12-27 20:49 ` Neil Horman
2015-01-15 13:12 ` Thomas Monjalon
2015-01-19 2:45 ` Zhang, Helin
2015-01-19 7:21 ` David Marchand
2015-01-19 9:13 ` Thomas Monjalon
2015-01-19 9:30 ` Qiu, Michael
2015-01-19 9:49 ` David Marchand
2015-01-19 10:02 ` Qiu, Michael [this message]
2015-01-19 10:07 ` Qiu, Michael
2015-01-19 17:07 ` Ravi Kerur
2015-01-19 22:07 ` Ravi Kerur
2015-01-19 9:14 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533710CFB86FA344BFBF2D6802E60286CB753D@SHSMSX101.ccr.corp.intel.com \
--to=michael.qiu@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).