Re: [dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check

["Qiu, Michael" <michael.qiu@intel.com>]

On 1/27/2015 6:02 PM, Thomas Monjalon wrote:
> Hi Michael,
>
> I'm clearly not the maintainer of ixgbe, so I'd prefer someone else
> reviewing this patch. However I have few comments.

Thanks Thomas,

I will send v2 with your comments.

But who maintains ixgbe? I would like add him(or she) to the cc list.

> 2015-01-15 22:45, Michael Qiu:
>> -	ixgbe_dev_rxtx_start(dev);
>> +	err = ixgbe_dev_rxtx_start(dev);
>> +	if (err < 0) {
>> +		PMD_INIT_LOG(ERR, "Unable to start rxtx queues\n");
> \n is not needed in PMD_INIT_LOG.
>
> Is this useful to print a log here, given that there already has
> some logs in ixgbe_dev_rxtx_start?

You are right, what I'm opinion is to show more details about the error,
but seems duplicated.

I will remove it.

Thanks,
Michael
>
>> +				PMD_INIT_LOG(ERR, "Start tx queue failed\n");
> [...]
>> +				PMD_INIT_LOG(ERR, "Start rx queue failed\n");
> Please remove \n.
>
> Except these minor comments, it looks good.
> Thanks