From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CCE425F66 for ; Tue, 27 Jan 2015 13:01:05 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 27 Jan 2015 03:57:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,474,1418112000"; d="scan'208";a="668311500" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga002.fm.intel.com with ESMTP; 27 Jan 2015 04:01:02 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 27 Jan 2015 20:01:01 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.64]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0195.001; Tue, 27 Jan 2015 20:01:00 +0800 From: "Qiu, Michael" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check Thread-Index: AQHQMNHv4jRlB7TeZky4c6T0HyTfpQ== Date: Tue, 27 Jan 2015 12:00:59 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CBAD55@SHSMSX101.ccr.corp.intel.com> References: <1421333111-22136-1-git-send-email-michael.qiu@intel.com> <3276396.omH03JUPtz@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 12:01:06 -0000 On 1/27/2015 6:02 PM, Thomas Monjalon wrote:=0A= > Hi Michael,=0A= >=0A= > I'm clearly not the maintainer of ixgbe, so I'd prefer someone else=0A= > reviewing this patch. However I have few comments.=0A= =0A= Thanks Thomas,=0A= =0A= I will send v2 with your comments.=0A= =0A= But who maintains ixgbe? I would like add him(or she) to the cc list.=0A= =0A= > 2015-01-15 22:45, Michael Qiu:=0A= >> - ixgbe_dev_rxtx_start(dev);=0A= >> + err =3D ixgbe_dev_rxtx_start(dev);=0A= >> + if (err < 0) {=0A= >> + PMD_INIT_LOG(ERR, "Unable to start rxtx queues\n");=0A= > \n is not needed in PMD_INIT_LOG.=0A= >=0A= > Is this useful to print a log here, given that there already has=0A= > some logs in ixgbe_dev_rxtx_start?=0A= =0A= You are right, what I'm opinion is to show more details about the error,=0A= but seems duplicated.=0A= =0A= I will remove it.=0A= =0A= Thanks,=0A= Michael=0A= >=0A= >> + PMD_INIT_LOG(ERR, "Start tx queue failed\n");=0A= > [...]=0A= >> + PMD_INIT_LOG(ERR, "Start rx queue failed\n");=0A= > Please remove \n.=0A= >=0A= > Except these minor comments, it looks good.=0A= > Thanks=0A= =0A=