From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 8F0A8AD94 for ; Fri, 13 Feb 2015 03:57:05 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 12 Feb 2015 18:53:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,568,1418112000"; d="scan'208";a="677301567" Received: from pgsmsx108.gar.corp.intel.com ([10.221.44.103]) by fmsmga002.fm.intel.com with ESMTP; 12 Feb 2015 18:57:03 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 13 Feb 2015 10:57:00 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.192]) by shsmsx102.ccr.corp.intel.com ([169.254.2.62]) with mapi id 14.03.0195.001; Fri, 13 Feb 2015 10:57:00 +0800 From: "Qiu, Michael" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver Thread-Index: AQHQRf5OXAG7d59Q8EabITlO4bpGVA== Date: Fri, 13 Feb 2015 02:56:58 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CE8F2C@SHSMSX101.ccr.corp.intel.com> References: <1423653001-11660-1-git-send-email-michael.qiu@intel.com> <1423661155-16645-1-git-send-email-michael.qiu@intel.com> <1893948.saDpN2FujX@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 02:57:06 -0000 On 2/13/2015 12:26 AM, Thomas Monjalon wrote:=0A= > 2015-02-11 21:25, Michael Qiu:=0A= >> max_vfs will only be created by igb_uio driver, for other=0A= >> drivers like vfio or pci_uio_generic, max_vfs will miss.=0A= >>=0A= >> But sriov_numvfs is not driver related, just get the vf numbers=0A= >> from that field.=0A= >>=0A= >> Signed-off-by: Michael Qiu =0A= > [...]=0A= >> snprintf(filename, sizeof(filename), "%s/max_vfs", dirname);=0A= >> if (!access(filename, F_OK) &&=0A= >> - eal_parse_sysfs_value(filename, &tmp) =3D=3D 0) {=0A= >> + eal_parse_sysfs_value(filename, &tmp) =3D=3D 0)=0A= >> dev->max_vfs =3D (uint16_t)tmp;=0A= >> + else {=0A= >> + /* for none igb_uio driver, need kernel=0A= > I think it's a typo. Do you mean "for non igb_uio driver"?=0A= =0A= Hi, Thomas=0A= =0A= Yes, you are right.=0A= =0A= Did I need to send out V3 patch for this typo?=0A= =0A= Thanks,=0A= Michael=0A= >=0A= >> + * version greater than 3.8 */=0A= >> + snprintf(filename, sizeof(filename),=0A= >> + "%s/sriov_numvfs", dirname);=0A= >> + if (!access(filename, F_OK) &&=0A= >> + eal_parse_sysfs_value(filename, &tmp) =3D=3D 0)=0A= >> + dev->max_vfs =3D (uint16_t)tmp;=0A= >> }=0A= >> =0A= >> /* get numa node */=0A= >>=0A= >=0A= =0A=