From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F262F5A76 for ; Thu, 5 Mar 2015 10:13:23 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 05 Mar 2015 01:08:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,345,1422950400"; d="scan'208";a="462833278" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by FMSMGA003.fm.intel.com with ESMTP; 05 Mar 2015 01:07:02 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 5 Mar 2015 17:13:15 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.192]) by shsmsx102.ccr.corp.intel.com ([169.254.2.62]) with mapi id 14.03.0195.001; Thu, 5 Mar 2015 17:13:14 +0800 From: "Qiu, Michael" To: Thomas Monjalon , David Marchand Thread-Topic: [dpdk-dev] [PATCH] eal/linux: fix build Thread-Index: AQHQVY6Cgc0zJNPTWUa046xl2/jCaA== Date: Thu, 5 Mar 2015 09:13:13 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CEED33@SHSMSX101.ccr.corp.intel.com> References: <1425372295-27839-1-git-send-email-thomas.monjalon@6wind.com> <1637153.LCrn9VkBbJ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2015 09:13:24 -0000 On 3/4/2015 6:24 AM, Thomas Monjalon wrote:=0A= >>> Compilation fails in some distributions because of missing unistd.h=0A= >>> needed for pread/pwrite (seen with Suse):=0A= >>> lib/librte_eal/linuxapp/eal/eal_pci_uio.c:62:2:=0A= >>> error: implicit declaration of function =91pread=92=0A= >>>=0A= >>> Fixes: 4a499c649590 ("eal/linux: enable uio_pci_generic support")=0A= >>>=0A= >>> Signed-off-by: Thomas Monjalon =0A= >> Acked-by: David Marchand =0A= > Applied=0A= =0A= Hi, Thomas=0A= =0A= This patch may be need to be reverted, as the error still exists.=0A= =0A= suse-11-sp3-32:~/dpdk # uname -a=0A= Linux suse-11-sp3-32 3.0.76-0.11-pae #1 SMP Fri Jun 14 08:21:43 UTC 2013=0A= (ccab990) i686 i686 i386 GNU/Linux=0A= =0A= suse-11-sp3-32:~/dpdk # gcc -v=0A= Using built-in specs.=0A= COLLECT_GCC=3Dgcc=0A= COLLECT_LTO_WRAPPER=3D/usr/local/libexec/gcc/i686-pc-linux-gnu/4.5.1/lto-wr= apper=0A= Target: i686-pc-linux-gnu=0A= Configured with: ./configure=0A= Thread model: posix=0A= gcc version 4.5.1 (GCC)=0A= =0A= As I try to check the manual of pread, find that it has two:=0A= ----------------------------------------------------------=0A= Man: find all matching manual pages=0A= * pread (2)=0A= pread (3p)=0A= Man: What manual page do you want?=0A= Man:=0A= -------------------------------------------------------------=0A= PREAD(2) Linux=0A= Programmer's=0A= Manual PREAD(2)=0A= =0A= =0A= =0A= NAME=0A= pread, pwrite - read from or write to a file descriptor at a=0A= given offset=0A= =0A= SYNOPSIS=0A= #define _XOPEN_SOURCE 500=0A= =0A= #include =0A= =0A= ssize_t pread(int fd, void *buf, size_t count, off_t offset);=0A= =0A= ssize_t pwrite(int fd, const void *buf, size_t count, off_t offset);= =0A= =0A= ---------------------------------------------------------------------------= -----------------------------------------------------------------=0A= =0A= READ(3P) POSIX=0A= Programmer's=0A= Manual READ(3P)=0A= =0A= =0A= =0A= PROLOG=0A= This manual page is part of the POSIX Programmer's Manual. The=0A= Linux implementation of this interface may differ (consult the=0A= corresponding Linux=0A= manual page for details of Linux behavior), or the interface may=0A= not be implemented on Linux.=0A= =0A= NAME=0A= pread, read - read from a file=0A= =0A= SYNOPSIS=0A= #include =0A= =0A= =0A= =0A= ssize_t pread(int fildes, void *buf, size_t nbyte, off_t offset);=0A= ssize_t read(int fildes, void *buf, size_t nbyte);=0A= =0A= =0A= DESCRIPTION=0A= =0A= ---------------------------------------------------------------------------= ---------------------------------------------------------------=0A= =0A= While I try to add marco #define _XOPEN_SOURCE 500=0A= =0A= Other errors show up=0A= =0A= Who knows how to solve this issue?=0A= =0A= Thanks,=0A= Michael=0A= =0A= >=0A= =0A=